Bug#862368: scan-copyrights fails to consolidate when licensecheck doesn't report years

[Paul Gevers]

Package: libconfig-model-dpkg-perl
Version: 2.090
Severity: normal
File: /usr/bin/scan-copyrights

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

Hi Dominique,

Because I like the promises of cme, I decided to try and use it again on a new
package I am working on. It failed on my in the past on too big source trees,
but now I decided to try harder.

I try to package tablesorter¹ (now in jquery-goodies). However, when I run
scan-copyrights (after tweaking some copyright-scan-patterns.yml and
fill.copyright.blanks.yml) it fails with the following message:

Can't call method "consolidate" on an undefined value at /usr/share/perl5/Dpkg/Copyright/Scanner.pm line 486.

I bisected this, and it turns out that I can reproduce this with two files
present (which indivially are fine) but when both present, it goes wrong. I
believe the problem is that licensecheck didn't find year for the copyright,
and a common copyright-holder for the two files.

paul at testavoira ~/packages/javascript/jquery-tablesorter/docs/js $ ll
total 112
drwxr-xr-x 2 paul paul  4096 mei 11 21:32 .
drwxr-xr-x 7 paul paul 12288 mei 10 21:25 ..
- -rw-r--r-- 1 paul paul 86659 mei 11 21:32 jquery-latest.min.js
- -rw-r--r-- 1 paul paul  7083 mei 11 21:32 jquery-migrate-3.0.0.min.js

paul at testavoira ~/packages/javascript/jquery-tablesorter/docs/js $ licensecheck --copyright .
./jquery-latest.min.js: UNKNOWN
  [Copyright: JS Foundation and other contributors | jquery.org/license]

./jquery-migrate-3.0.0.min.js: UNKNOWN
  [Copyright: jQuery Foundation and other contributors | jquery.org/license]

Please let me know if you need more info.

Paul

¹ https://github.com/Mottie/tablesorter

- -- System Information:
Debian Release: 9.0
  APT prefers testing-debug
  APT policy: (500, 'testing-debug'), (500, 'testing'), (200, 'experimental'), (200, 'testing'), (50, 'experimental'), (50, 'testing'), (1, 'experimental')
Architecture: amd64
 (x86_64)

Kernel: Linux 4.9.0-2-amd64 (SMP w/2 CPU cores)
Locale: LANG=en_US.UTF-8, LC_CTYPE=en_US.UTF-8 (charmap=UTF-8)
Shell: /bin/sh linked to /bin/dash
Init: systemd (via /run/systemd/system)

Versions of packages libconfig-model-dpkg-perl depends on:
ii  libapt-pkg-perl                              0.1.32
ii  libarray-intspan-perl                        2.003-1
ii  libconfig-model-perl                         2.097-1
ii  libexporter-lite-perl                        0.08-1
ii  liblog-log4perl-perl                         1.48-1
ii  libmouse-perl                                2.4.7-1
ii  libparse-recdescent-perl                     1.967013+dfsg-1
ii  libsoftware-license-perl                     0.103012-1
ii  libtext-autoformat-perl                      1.740000-2
ii  libtext-levenshtein-damerau-perl             0.41-1
ii  liburi-perl                                  1.71-1
ii  libwww-perl                                  6.15-1
ii  libyaml-perl                                 1.21-1
ii  licensecheck                                 3.0.29-1
ii  lintian                                      2.5.50.3
ii  perl                                         5.24.1-2
ii  perl-modules-5.22 [libmodule-corelist-perl]  5.22.2-5
ii  perl-modules-5.24 [libmodule-corelist-perl]  5.24.1-2

Versions of packages libconfig-model-dpkg-perl recommends:
ii  libconfig-model-tkui-perl  1.361-1

libconfig-model-dpkg-perl suggests no packages.

- -- no debconf information

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEEWLZtSHNr6TsFLeZynFyZ6wW9dQoFAlkUvzIACgkQnFyZ6wW9
dQoTOQf/U9MsMTMLb3vSwbuWqTIDNv9gu7Ag54X8v46OjpkOBuss243E+bbp/jip
CQoqz+vYo/j+qn3Oz1A5sZm8TffTRY3ScKWZhMv9RsbUqjIR6KHkbpsjTsUAyHL0
iD7+VmvPFxxNrzlReagDZGlzwqfFsflb4ykr2lfjqpijV1nMgw0i+9hNR9P7rMWy
dPHo/1UH/93lm+jMo82GmwdWoihmtZ1R1aqEllHdIqhwDItYmQ3VfKIoqvfNgthH
+wuI5XstwkDh+Sqv/ymxVSzYXcQ7rnlhQtfDoPsvu5nSyKg+ZU3avh5BSaAU0jnq
4dAXkYAloQk3O7Nddfl/6eMbZCXzyQ==
=0SNP
-----END PGP SIGNATURE-----