Bug#862748: libnmap-parser-perl: not all service fields are parsed

[gregor herrmann]

Control: forwarded -1 https://rt.cpan.org/Ticket/Display.html?id=96867

On Tue, 16 May 2017 17:18:14 +0200, Peter Gervai wrote:

> You should parse more ;)
> (Generally you should parse all other fields, known or else.)
> 
> 
> --- Parser.pm.orig      2017-05-16 17:13:54.717701138 +0200
> +++ Parser.pm   2017-05-16 17:13:58.997635383 +0200
> @@ -434,6 +434,9 @@
>          $service_hashref->{method}      = $service->{att}->{method};
>          $service_hashref->{confidence}  = $service->{att}->{conf};
>          $service_hashref->{fingerprint} = $service->{att}->{servicefp};
> +       # more
> +       $service_hashref->{hostname}    = $service->{att}->{hostname};
> +       $service_hashref->{ostype}      = $service->{att}->{ostype};
>      }
>  
>      return $service_hashref;
> 

Thanks, I've added your proposal to to upstream ticket at
https://rt.cpan.org/Ticket/Display.html?id=96867
where a similar change was already requested.


Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at/ - Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Joan Baez: Don't cry for me argentina
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: Digital Signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20170516/6ee16358/attachment.sig>