Bug#1021511: liburi-perl: URI 5.13 breaks Net::Twitter::Lite::WithAPIv1_1 and Net::Twitter

[gregor herrmann]

Control: retitle -1 liburi-perl: URI 5.13 breaks Net::Twitter::Lite::WithAPIv1_1 and Net::Twitter
Control: forwarded -1 https://github.com/libwww-perl/URI/issues/111
COntrol: severity -1 serious

On Sun, 09 Oct 2022 23:42:47 +0200, gregor herrmann wrote:

> HTTP Response Code: 400
> HTTP Message......: Bad Request
> Twitter error.....: 400: Bad Request
> twitter_error.....: $VAR1 = [
>           {
>             'code' => 215,
>             'message' => 'Bad Authentication data.'
>           }
>         ];
> 
> After checking which package I had updated recently I found that liburi-perl
> is the culprit; after downgrading to 5.12-1 the errors are gone.

Same with Net::Twitter / libnet-twitter-perl
 
> No further debugging so far … So maybe libnet-twitter-lite-perl is
> the problem and needs to adjust.

My gut feeling is that
https://github.com/libwww-perl/URI/commit/1a4ed66802f26c15cccd66c0b5d489cf9f3e3ba4
might be the cause, which changes uri_escape and is used in both
Net::Twitter::Lite::WithAPIv1_1 and Net::Twitter:

% grep -r uri_escape libnet-twitter-{,lite-}perl
libnet-twitter-perl/lib/Net/Twitter/Core.pm:        push @pairs, join '=', map URI::Escape::uri_escape_utf8($_,'^\w.~-'), $k, $v;
libnet-twitter-lite-perl/lib/Net/Twitter/Lite.pm:            push @pairs, join '=', map URI::Escape::uri_escape_utf8($_, '^A-Za-z0-9\-\._~'), $k, $v;
libnet-twitter-lite-perl/lib/Net/Twitter/Lite.pm:            $path .= uri_escape($id);

Ah, and there is a new Github issue:
https://github.com/libwww-perl/URI/issues/111

(Updating bug metadata, "serious" to keep it out of testing, if still
possible.)

Cheers,
gregor

-- 
 .''`.  https://info.comodo.priv.at -- Debian Developer https://www.debian.org
 : :' : OpenPGP fingerprint D1E1 316E 93A7 60A8 104D  85FA BB3A 6801 8649 AA06
 `. `'  Member VIBE!AT & SPI Inc. -- Supporter Free Software Foundation Europe
   `-   
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 963 bytes
Desc: Digital Signature
URL: <http://alioth-lists.debian.net/pipermail/pkg-perl-maintainers/attachments/20221010/cf23b8ce/attachment.sig>