[Pkg-phototools-devel] Bug#554494: Bug#554494: pfstools: diff for NMU version 1.8.1-1.1

[Sebastian Harl]

Hi,

On Sun, Dec 20, 2009 at 03:35:07PM +0100, Stefano Zacchiroli wrote:
> I've prepared an NMU for pfstools (versioned as 1.8.1-1.1) and uploaded
> it to DELAYED/2, according to devref §5.11.1.

Thanks a lot for taking care of that!

> The patch is the one from Ubuntu which has been posted to the bug log
> a while ago. The rationale of the patch is that in fact that variable
> is not being used as a "const" char *, hence the declaration should be
> dropped.

I still think that the variable is correctly used as a "const char *":
It's used once as the first argument to strchr(), which, according to
POSIX, is a "const char *" and once as the only argument to string(),
which, according to the [C++ reference], accepts a "const char *" as
well.

So, imho, this rather sounds like a bug/misbehavior in libc to me.
Anyway, I did not have time to dig into that further (and, thus, lost
track of that bug :-/). Possibly, libc behaves correctly, if the "right"
defines are used. Also, this patch does not have any real disadvantages
from my point of view, so I'm fine with it.

Thanks again for the NMU!

Cheers,
Sebastian

[C++ reference] http://www.cplusplus.com/reference/string/string/string/

-- 
Sebastian "tokkee" Harl +++ GnuPG-ID: 0x8501C7FC +++ http://tokkee.org/

Those who would give up Essential Liberty to purchase a little Temporary
Safety, deserve neither Liberty nor Safety.         -- Benjamin Franklin

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 197 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-phototools-devel/attachments/20091220/de664c4b/attachment.pgp>