[pkg-php-pear] Let's reconsider the way Symfony2 Components are packaged for Debian

[David Prévot]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256

[ Dropping the ITP for the review. ]

Hi Daniel,

> Le 29/05/2014 14:15, Daniel Beyer a écrit :

>> I've pushed some initial packaging, which can be found at:
>> http://anonscm.debian.org/gitweb/?p=pkg-php/php-symfony.git;a=summary

I had a quick look at the content of the debian/ directory, thanks for
your work. Here are a few things that popped up (not all item may
deserve to be acted upon, but I’d like if you could share your rationale
if you don’t wish to do so). Do not hesitate to ask for clarifications
of what follows.

Some general thoughts :
- - You may wish to name the source package simply “symfony”.
- - You may wish to also track the upstream Git repository:
http://honk.sigxcpu.org/projects/git-buildpackage/manual-html/gbp.import.html#GBP.IMPORT.UPSTREAM.GIT.TARBALL
- - You may follow the default upstream/master gbp branch naming and
ignore the specific upstream-$suite/debian-$suite that doesn’t give any
gain TTBOMK (and yes, I know this is advised by the current team policy
for PEAR packages).
- - There might be files that need to be stripped away from the upstream
tarball (e.g., sourceless Windows specific-files): php-symfony-console
has a +dfsg version.

Some initial remarks:
- - Please, do not start synopsis with an uppercase:
https://www.debian.org/doc/manuals/developers-reference/best-pkging-practices.html#bpp-pkg-synopsis
- - The first php-symfony-components metapackage may be simply renamed as
“symfony” and should be in section “metapackages”.
- - You should keep a common part at the end of the long description, as
was done in most current php-symfony-* packages.
- - Please, don’t use “php” nor “psr-0” in text, prefer the accurate
uppercase “PHP” and “PSR-0” versions.
- - Please, don’t use “MIT” as license name, but Expat:
https://www.debian.org/doc/packaging-manuals/copyright-format/1.0/#license-specification
- - Please, consider distributing the packaging with the same license as
upstream.
- - The hard-coded export-dir in packages’ gbp.conf breaks many tools
(e.g., debi) and forces a workflow not shared by everyone, please
consider adding it to your own ~/.gbp.conf instead (and yes, I know this
is another advice you may have followed from the team policy).
- - I’ve not dug up into the complex d/rules yet, but you may use d/tmp
instead of d/build that will not need an override_dh_auto_clean. I like
the idea and the intent of d/rules, but adding some comments may help
the review and the hacking.
- - d/watch may be explicit about the 2.3 branch you intend to track.

Regards

David

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBCAAGBQJTjOhMAAoJEAWMHPlE9r08fwwH/RDPk08kEh3nBhdWcAYo9MwD
NgBjPlnGhJN8+GTquDTNm0oxxo9jfhx83kAOVLN+SwZd/De9Ai39KtLCDFOxhYcv
XF5pc8VmrMehqQUyIu7eIPuU3F5RrAL59b72iaxMtsVxPaW4sQBKd7eLoJYaX0yr
c/7ReymrutrsD4Lia/CLtQ2qDtb5ZimXOzxcaZ43rx61GTyjWFCrY4BT8jwMzgmN
wlkKNRb40gt5Rf4Sc/MPHATYoxpBKno906LwKdyelf5koitqtK67nLiWhRLFD+aL
vA9KnkHdQuFJRVanCujzvNj4PfeZmlxFooU2LOThyQGb3mV+z/LjpWMcG5/5+zw=
=tUvq
-----END PGP SIGNATURE-----