[pkg-php-pear] Wiki feedback [Was: deb packages looking for sponsorship]

[Fab Stz]

Hello,

Le lundi 6 juin 2022, 09:25:10 CEST David Prévot a écrit :
> > What is the right/modern way that I should use then?
> > - d/rules with `dh --with addon`
> > - or d/control with `dh-sequence-addon` ?
> 
> The last one.

Ok. Thanks


> > IIRC when cleaning and unpacking is done during dpkg-buildpackage it says
> > that the directories created by `mkdir --parents vendor <Vendor_name>`
> > in override_dh_auto_build are not in the orig tar, so dpkg-buildpackage
> > failed.
> 
> I never notice such problem. That rather seems like a bug in our 
> tooling. Can you please point to some reference, or report it if you’re 
> able to reproduce it (I can’t).

I can't reproduce it either. Probably by that time I didn't have the correct 
values in d/clean.

> > I changed the wiki and moved this part into this target:
> > execute_before_dh_auto_test:
> > I also move the first part to execute_before_dh_auto_build instead of
> > override_dh_auto_build
> > 
> > Hopefully this is correct.
> 
> See above (i.e., not sure).

I thinks it is better that ways because it doesn't override `dh_auto_build` 
but just runs the necessary commands in `execute_before_dh_auto_build` target.

And for the tests, the necessary files are created just before running 
dh_auto_test in the `execute_before_dh_auto_test` target. These files are not 
needed if the tests are not run, hence I think it's more accurate to have them 
in execute_before_dh_auto_test rather than execute_before_dh_auto_build or 
override_dh_auto_build.

> >>> * Since the packages used for the tests are already in d/control
> >>> What about using `@builddeps@` in the Depends field of d/tests/control
> >>> ?
> >>
> >> Checking that the package dependencies are correct is also part of the
> >> autopkgtest features.
> >>
> >>       […]
> >>       please use this sparingly, as this can easily lead to missing
> >>       binary
> >>       package dependencies being overlooked if they get pulled in via
> >>       build dependencies.
> 
> […]
> 
> > I'm not sure to understand the warning. The package in itself doesn't need
> > the
 dependencies used in the tests (that I put in d/control's build-deps
> > so that test target works), so I can use @builddeps@ in d/tests/control
> > without problem right?
> 
> No. “Depends:” in d/t/control should only contain the additional 
> dependencies needed to run the tests. It helps noticing, e.g., a missing 
> package dependency (“Depends” in d/control) during the tests. 
> @builddeps@ is like a WMD that helps when the tests needs so many 
> packages that it’s a PITA to synchronize everything. Few packages, if 
> any, on top of the usual three (phpab, phpunit, pkg-php-tools) does not 
> qualify as a good use of this WMD.

OK, thanks.

> > (please leave my email in the recipients when doing a reply to all since
> > some
 messages seems to not arrive on the mail I used to subscribe to the
> > list)
> 
> Done, but please, do not CC me, as per our lists CoC.
> 
> 	https://www.debian.org/MailingLists/#codeofconduct

Thanks for the notice, I didn't know that and it doesn't seem to be followed 
on all lists.

Rgds
Fab