[ProFTP] Build modules equally

[Hilmar Preuße]

On 30.04.2018 21:08, Francesco P. Lovergine wrote:
> On Mon, Apr 30, 2018 at 01:24:41PM +0200, Hilmar Preuße wrote:

Hi,

>> the upstream .orig.tar.gz files of most modules look equally. Hence I'd
>> expect that they are built equally. I'd expect that the files in debian/
>> only differ in the module name and the package description. I think
>> about a package template, which should make it easy to package more
>> proftp modules for Debian.
>>
<snip>
>> I'd then use the one from autohost...or the one from vroot? This one is
>> at least verified to work as there are released files.
>>
>> opts=filenamemangle=s/.+\/v?(\d\S*)\.tar\.gz/proftpd-mod_vroot-$1\.tar\.gz/
>>
>> \
>>  https://github.com/Castaglia/proftpd-mod_vroot/tags
>> .*/v?(\d\S*)\.tar\.gz
>>
> 
> Currently we should be able to use the same pattern for most of the 
> modules, because TJ uses github for all of them.
> 
Implemented on salsa. For a few package it is proven that the
opts=filenamemangle variant works.

>> 2. Most module package build only a single package. Therefore I'd expect
>> that most files in debian/ (dirs, docs, etc.) are not named like the
>> binary package.
>>
>> example:
>> hille at sid:~/devel/proftp/aaa_git/proftpd-mod-autohost/debian $ ls -l
>> proftpd-mod-autohost.*
>> -rw-r--r-- 1 hille users  44 Apr 28 17:08 proftpd-mod-autohost.dirs
>> -rw-r--r-- 1 hille users 320 Apr 28 17:08 proftpd-mod-autohost.doc-base
>> -rw-r--r-- 1 hille users  67 Apr 28 17:08 proftpd-mod-autohost.install
>> -rw-r--r-- 1 hille users  91 Apr 28 17:08 proftpd-mod-autohost.links
>>
>> Any specific reason why the long names were used, instead of the short
>> names?
> 
> Different modules had different autorships historically and that justifies
> the changes, among with different options used in dh_make (and different
> versions used).
> 
Hmm. I still see no justification to not use short file names. At least
the package still builds fine. Here is the content of debian/

hille at amd64-sid:~/devel/proftp_debian/build/proftpd-mod-autohost/debian$
ls -l
total 52
-rw-r--r-- 1 hille hille 1181 Mai  3 12:27 changelog
-rw-r--r-- 1 hille hille    2 Mai  3 12:27 compat
-rw-r--r-- 1 hille hille 1490 Mai  3 12:27 control
-rw-r--r-- 1 hille hille 1093 Mai  3 12:27 copyright
-rw-r--r-- 1 hille hille   44 Mai  3 12:27 dirs
-rw-r--r-- 1 hille hille  320 Mai  3 12:27 doc-base
-rw-r--r-- 1 hille hille   18 Mai  3 12:27 docs
-rw-r--r-- 1 hille hille   67 Mai  3 12:27 install
-rw-r--r-- 1 hille hille   91 Mai  3 12:27 links
-rwxr-xr-x 1 hille hille  621 Mai  3 12:27 rules
drwxr-xr-x 2 hille hille 4096 Mai  3 12:27 source
drwxr-xr-x 2 hille hille 4096 Mai  3 12:27 templates
-rw-r--r-- 1 hille hille  170 Mai  3 12:27 watch

I'd not expect that a module source package generates more than one
binary package. ;-)

Hilmar
-- 
#206401 http://counter.li.org