[DRE-maint] Sponsoring sinatra web DSL framework ?

[Lucas Nussbaum]

On 25/06/09 at 20:12 +0200, Laurent Vallar wrote:
> Hi,
> 
> On Wed,Jun,24,2009, Lucas Nussbaum wrote:
> > On 24/06/09 at 17:05 +0200, Laurent Vallar wrote:
> > > I did package sinatra web DSL framework, it can be found there :
> > > http://zbla.net/debian/sinatra-0.9.3-1/
> > 
> > I get an error 403 when trying to download the .orig.tar.gz file.
> >
> 
> It is fixed, sorry.
> 
> > > I know there is some lintian bugs, i'll correct it but what to do when
> > > lintian said that :
> > > 
> > > W: sinatra: extra-license-file usr/share/doc/sinatra/LICENSE
> > 
> > see http://lintian.debian.org/tags/extra-license-file.html
> > 
> > You should not install that file in /usr/share/doc/
> > 
> 
> All lintian's warning are fixed now, i hope ;)
> 
> > > [...]
> > > May I send an ITP ? Can I do that ?
> > 
> > Sure. The best way to do that is to use reportbug, but you can do that
> > manually too.
> > 
> 
> Done.
> 
> > Regarding sponsoring, here are some random comments on the package (only
> > looking at the .diff.gz):
> > [...]
> 
> All of them are fixed now, thanks for your (good) advices.
> 
> I'm now looking for a new review on the package if someone can do that.
> 
> I hope it can be part of the next stable release as this framework is
> very usefull for quick and dirty web/RESTful backend. If any DD wants to
> maintain this package i will be happy...

Do you want to maintain it yourself? You could do that inside the team.
You would only need a DD to sponsor your uploads, and after some time,
you could apply for DM status (http://wiki.debian.org/Maintainers).

Other comments on your package:

changelog entry: you should use:
 * Initial release (Closes: #534557).
When generating the .changes file, there's some magic going on to find
the bugs that the upload closes, and automatically add a Closes: header
in the .changes. Currently, you have "* Close ITP #534557.", but that
doesn't match the regexp used to find bugs in the changelog.

your patches are not documented. It's not mandatory at all, but it would
be a good idea to document them. DEP3 (http://dep.debian.net/deps/dep3/)
provides some guidelines about that. It's not officially approved yet,
but it's not a reason not to try to follow it already.

If I remember correctly, you where using the cdbs setup.rb class
previously. Why did you change your mind? I really prefer to sponsor
packages using cdbs classes, since it makes writing debian/rules much
simpler in most cases.
You can do all the customization using overrides (there are lots of
examples in the pkg-ruby-extras svn repository).
-- 
| Lucas Nussbaum
| lucas at lucas-nussbaum.net   http://www.lucas-nussbaum.net/ |
| jabber: lucas at nussbaum.fr             GPG: 1024D/023B3F4F |