[Pkg-rust-maintainers] Bug#881845: Bug#881845: Bug#881845: Bug#881845: rustc: FTBFS on mips*: test failures

Ximin Luo infinity0 at debian.org
Wed Jul 25 04:01:00 BST 2018


YunQiang Su:
> Ximin Luo <infinity0 at debian.org> 于2018年7月25日周三 上午7:15写道:
>>
>> Can you explain what this patch does and file it to Rust upstream first so I can see that they think it's OK?
> 
> MIPS's default GOT size is small for performance, while for some big
> app, they may complain GOT is too small.
> So there is an complier time option `-mxgot' to force big GOT.
> That is what we meet here.
> 
>>
>> The first hunk seems like it should be conditioned on the target-architecture being mips64, rather than blanket applied to all architetcures.
>>
> 
> Yes, you are right. Can you fix it when apply?
> 
>> I'm also unsure if it's better being applied to ./src/librustc_target/spec/mips64{,el}_unknown_linux_gnuabi64.rs rather than these files.
>>

If -mxgot is required for all rust programs then the rustc upstream compiler should be patched to add this flag unconditionally, we shouldn't carry this patch in Debian.

I'd also like to get some comments from the Rust Project upstream that this is in fact the right way to solve the issue.

So from my position of ignorance I'm not yet confident enough to apply the patch like this, sorry.

X

-- 
GPG: ed25519/56034877E1F87C35
GPG: rsa4096/1318EFAC5FBBDBCE
https://github.com/infinity0/pubkeys.git



More information about the Pkg-rust-maintainers mailing list