[Pkg-samba-maint] About the include problem in client/mount.cifs.c

Christian Perrier bubulle at debian.org
Tue May 23 08:22:41 UTC 2006


When the 3.0.23pre1 version was announced at the end of April, Noèl
and myself quickly discovered that we weren't able to compile it
because of "include/version.h" not being found.

There are indeed several solutions to this:

-compile with "-I./"
-replace "  #include "include/version.h"  " by
         "  #include "../include/version.h"   "
 in both mount.cifs.c and umount.cifs.c
-define  MOUNT_CIFS_VENDOR_SUFFIX="Debian" which indeed seems pretty
 logical. This is done by adding the change in our patch named
 debian/patches/VERSION.patch

I will certainly go for the last solution unless someone objects.

However, it seems to me that upstream's code is not very consistent
with other files with regards with includes....I wonder whether we
should report this.

Steve, do you have an advice?

-- 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-samba-maint/attachments/20060523/e1804ac0/attachment.pgp


More information about the Pkg-samba-maint mailing list