[Pkg-samba-maint] Asking for review of ctdb package before asking for a sponsor

[Mathieu PARENT]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1


thanks,


On Jan 30, 2008 4:16 PM, Peter Eisentraut  wrote:
> Am Mittwoch, 30. Januar 2008 schrieb Mathieu PARENT:
> > My ctdb package is almost finished. I need some help to validate
> > against debian policy. This is my first package, so i may miss
> > some essential step.
>
> Some comments:
>
> * README.Debian:  It is content-free and redundant; remove it.
done
> * changelog:  Remove spaces before colons.
done
> * changelog:  I would separate the date from the version number by some other
> means, such as 1.0.24+git200801221422-1.
done
> * control:  It should be XS-Vcs-Svn and XS-Vcs-Browser.
done
> * control:  Put a slash at the end of XS-Vcs-Svn.
done
> * control:  There is a long list of Suggests, but it is not clear in what
> contexts those packages would be useful.

I have marked them as suggested because they are used by ctdb_diagnostic
which is not essential. Removed them.


> * control:  The description could use a few more sentences.
done, copied from http://ctdb.samba.org/
> * control:  If it depends on ethtool, it must be Priority extra.
done
> * control:  I don't think this package actually depends on logrotate.  That
> would be unusual.
done (suggests only)
> * docs:  You don't need to install README.build, as it is not useful for users
> of the package.
done
> * postinst, postrm, preinst, prerm:  Remove these, since they don't do
> anything.
done, i thought they were needed by debhelper, but it works without.
> * rules:  Clean up this file.  Remove all the comments "Add here ...", all the
> example commands that are commented out, all the targets you don't need.  The
> get-orig-source-bzr target is unclear to me, as ctdb uses git.
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
> > My get-orig-source target-git (in debian/rules) should call build-orig.sh
> > from the debian directory. How to do this ?
>
> Call sh debian/build-orig.sh I guess.
done
> > Should I use soname or something similar ?
>
> I don't see a library in your package.
ok

I have commited my changes to svn. The package is now signed : see
http://mathieu.parent.free.fr/debian/ctdb/ctdb_1.0.25+git200801291431-1.dsc

Mathieu Parent

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: http://firegpg.tuxfamily.org

iD8DBQFHoJ4uOW2jYf5fHX8RApmJAKCOOU59ene8p75cM+Ov74M/t2K0eQCfRWd4
J8BQC6Ny8OrlHBKCO+PUck8=
=sfNY
-----END PGP SIGNATURE-----