[Pkg-samba-maint] Bug#249873: Bug#249873: Patch

[Nikolaus Rath]

On 04/24/2012 12:42 AM, Christian PERRIER wrote:
>>
>> If think the proper solution is to drop the fhs-filespaths.patch and
>> make "private dir" default to upstreams layout, both in the installed
>> smb.conf and in the binary.
> 
> Yes. However, if we could avoid adding something to smb.conf, it would
> be good. We should default to upstream location (assuming that is is
> correct wrt FHS, now, which I haven't checked).
> 
>>
>> For migration, there would be a postinst script that checks if we are
>> updating from a previous package version and in that case either
>>
>> - move the private dir from /var/lib/samba to the new default, or
> 
> Yes, and move the data that's in that directory, which is the tricky
> part as we need to imagine all possible cases.
> 
>>
>> - adjust smb.conf such that "private dir" points to /var/lib/samba
> 
> I don't think we should change smb.conf in maintainer scripts.
> 
>> Which one would you prefer? Or were you thinking about something else
>> entirely?
> 
> 
> Clearly your first proposal.
> 
> The tricky point is: what to do if upstream doesn't default to
> /etc/samba/private as we still have to respect the FHS. I'd rather
> live with upstream's default temporarily, though, and convince them to
> change the default to make it FHS-compliant...or configurable at build
> time if it isn't yet).


Hmm. I think defaulting to /etc/samba/private now, only to have another
transition once we've convinced upstream to comply with FHS is inviting
trouble.

If we have to obey FHS, wouldn't it be much easier to just replace
fhs-filespaths.patch with a patch that replaces the *default* value for
"private dir" to /var/lib/samba/private?

In that case, the transition should be painless in almost all cases. No
data needs to be moved, and no smb.conf adjusted in most cases.

The only case that could cause problems is systems that have defined
"private dir" in smb.conf but relied on it being ignored. But these
cases could be handled by a warning in NEWS.Debian. If that's not
enough, we could have the postinst check smb.conf and give a warning if
"private dir" is defined. But I don't think that we have to care too
much about systems whose configuration relies on an obvious bug
(configuration setting being ignored).


Best,

   -Nikolaus

-- 
 »Time flies like an arrow, fruit flies like a Banana.«

  PGP fingerprint: 5B93 61F8 4EA2 E279 ABF6  02CF A9AD B7F8 AE4E 425C