[Pkg-samba-maint] Bug#653207: #653207 (smbclient: Smbclient 3.6.1 incompatible with BackupPC 3.2.1) said to be fixed upstream with 3.6.6, but 3.6.6-2 still shows the same problem

[Axel Beckert]

found 653207 2:3.6.6-2
affects 653207 backuppc
kthxbye

bts-link-upstream at lists.alioth.debian.org wrote:
> # bts-link upstream status pull for source package samba
> # see http://lists.debian.org/debian-devel-announce/2006/05/msg00001.html
[...]
> # remote status report for #653207 (http://bugs.debian.org/653207)
> # Bug title: smbclient: Smbclient 3.6.1 incompatible with BackupPC 3.2.1
> #  * https://bugzilla.samba.org/show_bug.cgi?id=8922
> #  * remote status changed: ASSIGNED -> RESOLVED
> #  * remote resolution changed: (?) -> FIXED
> #  * closed upstream
> tags 653207 + fixed-upstream
> usertags 653207 - status-ASSIGNED
> usertags 653207 + status-RESOLVED resolution-FIXED

According to WHATSNEW.txt in the source package of 3.6.6-2, the
upstream bug for #653207 has been fixed with 3.6.6:

    * BUG 8922: smbclient's tarmode insists on listing excluded directories.

I could also assure myself that the fix attached to the upstream bug
is part of the 3.6.6-2 source package.

But I can still reproduce this issue on Wheezy with 3.6.6-2:

Using tarmode still results in aborted transfers:

$ smbclient \\\\[...]\\C\$ somepassword -U backuppc -d 10 -E -c tarmode\ full -Tc test2.tar
[...]
(26.8555 kb/s) (average 7605.74 kb/s)
dos_clean_name [\boot.ini]
unix_clean_name [\boot.ini]
NT_STATUS_ACCESS_DENIED opening remote file \boot.ini (\)
lang_tdb_init: /usr/share/samba/en_US.UTF-8.msg: No such file or directory
NT_STATUS_ACCESS_DENIED listing \\*
tar: dumped 163 files and directories
Total bytes written: 7737856

The command above works as expected on Debian Squeeze with smbclient
2:3.5.6~dfsg-3squeeze6:

[...]
(53.7109 kb/s) (average 7926.66 kb/s)
dos_clean_name [\boot.ini]
unix_clean_name [\boot.ini]
NT_STATUS_ACCESS_DENIED opening remote file \boot.ini (\)
strlen(cur_dir)=1, strlen(finfo->name)=26
[...]

So it looks as if the upstream fix is either incomplete (in that case
I'd be happy if someone could reopen the bug upstream) or there are
actually two different issues.

The following patch reverts only one of the lines which have changed
between the Squeeze and the Wheezy version of Samba, but seems to
restore the previous behaviour in smbclient's tar mode:

--- samba-3.6.6/source3/client/client.c 2012-06-24 19:21:16.000000000 +0200
+++ to-wreck/samba-3.6.6/source3/client/client.c    2012-08-08 00:13:26.477734643 +0200
@@ -806,7 +806,6 @@
                status = do_list_fn(cli_state, f, dir);
        }
        TALLOC_FREE(dir);
-       return status;
 }
 
 /****************************************************************************

(It's at the end of the do_list_helper function.)

So far I tested only the example command above, i.e. I suspect that
simply applying this patch breaks other things and doesn't suffice.
But it shows where the remaining issue is likely located.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe at debian.org>, http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE
  `-    |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5