[Pkg-samba-maint] Bug#726472: share passwords not working after upgrade from samba3

[Andrew Bartlett]

On Sat, 2013-10-19 at 10:16 -0700, Steve Langasek wrote:
> On Sat, Oct 19, 2013 at 11:51:14AM +0200, Ivo De Decker wrote:
> 
> > Thanks for all the info. That really helps!
> 
> > On Fri, Oct 18, 2013 at 08:41:10PM -0500, Steve M. Robbins wrote:
> > > /var/lib/samba/:
> > > total 344
> > [...]
> > > -rw-------  1 root root       61440 Feb 16  2012 passdb.tdb
> 
> > 
> > > /var/lib/samba/private/:
> > > total 832
> > > -rw------- 1 root root 421888 Oct 15 23:14 passdb.tdb
> 
> > I think this is the issue. On upgrade from 3.x to 4.x, passdb.tdb gets moved
> > from /var/lib/samba/ to /var/lib/samba/private/.
> 
> > From samba.postinst:
> 
> > if dpkg --compare-versions "$2" lt-nl 2:4.0.6 \
> >     && [ -e /var/lib/samba/passdb.tdb ] \
> >     && ! [ -e /var/lib/samba/private/passdb.tdb ]
> > then
> >     mv /var/lib/samba/passdb.tdb /var/lib/samba/private/passdb.tdb
> > fi
> 
> > If this would have happened, the old /var/lib/samba/passdb.tdb wouldn't be
> > there anymore. I guess there was a /var/lib/samba/private/passdb.tdb before
> > the upgrade, which resulted in both files staying where they are. As the newer
> > version looks to /var/lib/samba/private/passdb.tdb, the old info wasn't
> > available anymore. After that, /var/lib/samba/private/passdb.tdb got changed
> > when you recreated the users.
> 
> Ok.  I think we need to undo this /var/lib/samba/private nonsense.  It is a
> pointless and imperfect migration (as shown by this bug report), and the
> only rationale upstream ever gave for keeping these files in a separate
> "private" directory is some stupid and ancient target OS that couldn't
> properly set per-file permissions.  Debian users have been using
> /var/lib/samba exclusively for the better part of a decade; migrating to
> this private/ directory adds no value for our users.

In the alternate, the only reason this happened now is because we are
finally having the Debian packages follow where upstream has decided to
put the files.  Having different packages moving files around to
different places only increases user confusion, and creates 'only on
Debian' bugs.  

For example, a significant number of issues came about as folks tried to
divine if a particular TDB was short, medium or long-term, when no such
separation existed in the code. 

We (upstream) have gone to significant effort to integrate the FHS
changes that have been proposed via Debian, I can only ask that having
got to a mutually agreed state, that Debian not change it again, having
once more Debian packages special and different. 

Or in the alternate, propose such changes upstream. 

Andrew Bartlett

-- 
Andrew Bartlett                                http://samba.org/~abartlet/
Authentication Developer, Samba Team           http://samba.org