[Pkg-security-team] Co-maintenance of pixiewps and/or wafw00f

[Gianfranco Costamagna]

Hi Samuel,
>I've just added some little tweaks to Daniel's manpage and now i believe we're ready to upload pixiewps.
>
>
>Can anybody from the team review the package and upload it, please? (just pixiewps, wafw00f's not ready yet)



I did change the patch a little bit, let me know if you are happy with it, and please forward changes upstream,
and I'll probably sponsor it
https://anonscm.debian.org/cgit/pkg-security/pixiewps.git/commit/?id=7dff6890804a4e62c4d2c47d548269a01dab07f7

>​Did you have a look at wafw00f? I still did not have time to dig into the python problem.
"the Python problem" is not quite clear to me, but a quick look shows me that
this one is missing: http://git.kali.org/gitweb/?p=packages/python-pluginbase.git;a=summary
(listed in install_requires)

same for beautifulsoup (you need to ask to package the new version)

Build-Depends: debhelper (>=9),
-               python-setuptools
+               python-setuptools,

+               python-beautifulsoup

dh-python missing
and runtime dependency too
-         ${misc:Depends}
+         ${misc:Depends}, ${python:Depends}


-       dh $@
+       dh $@ --with python2


not sure why you have static runtime dependencies, not listed in install_requires and in build-dependencies

in some way dh_python should fill python:Depends by itself

I'll review with more depth as soon as I understand more the issue you have with the package :)

G.