[Pkg-security] mdk3 sponsor

Samuel Henrique samueloph at gmail.com
Wed Oct 19 01:42:54 UTC 2016


Hi Gianfranco,

review done and changes pushed on git :)
>
> Please upstream patches
>

Patches sent :) (via email)


changes:
> - Make installation configurable
>
> - Remove useless debian/dirs
> - Put flags at the end, to avoid link failures when Wl, asneeded is the
> default
>
> (e.g. Ubuntu)
>
> - Fix build installation
>
> let me know if you like them or not!
>

So for so good, i had absolutely no idea about that problem with "WL,
asneeded" and flag order, i should be paying attention for that in the
future.

All the changes looks good to me, i've renamed one patch you made from
fix-install.patch to fix_install.patch in order to follow other patch's
names.

BTW also lintian should be fixed in a future upload:
> P: mdk3 source: source-contains-svn-control-dir osdep/radiotap/.svn
>
> and licensecheck
>
> licensecheck * -r
>
> *: GPL (v2 or later) (with incorrect FSF address)
>

If i understood correctly, debhelper doesn't ship these .svn files, so its
more of a cosmetic change, right? Don't get me wrong, this ~should~ be
fixed, but we can wait for an upstream fix.

I've just commited a patch that fixes the FSF address, so that's one
problem less.

awesome, you are now DM for t50, please do source-only uploads, and give me
> good packages if you want DM permissions for something else
> (I have to sponsor each package once for you before granting them, sorry!)
>

Awesome it is! Thanks for the dak and advocacy Gianfranco, i understand
your worry about granting permission on another packages.

I believe we're ready to upload mdk3, if you agree with my last changes,
please feel free to send it up.

Regards,

Samuel Henrique <samueloph>

2016-10-17 17:12 GMT-02:00 Gianfranco Costamagna <locutusofborg at debian.org>:

> Hi Samuel!
>
> >I've just finished the packaging of mdk3 and would like someone to review
> and upload the package.
>
>
> review done and changes pushed on git :)
>
> Please upstream patches
>
> changes:
> - Make installation configurable
>
> - Remove useless debian/dirs
> - Put flags at the end, to avoid link failures when Wl, asneeded is the
> default
>
> (e.g. Ubuntu)
>
> - Fix build installation
>
> let me know if you like them or not!
>
> BTW also lintian should be fixed in a future upload:
> P: mdk3 source: source-contains-svn-control-dir osdep/radiotap/.svn
>
> and licensecheck
>
> licensecheck * -r
>
> *: GPL (v2 or later) (with incorrect FSF address)
>
> >My key got added to the keyring about one week ago, so if someone could
> grant me upload rights to the packages i maintain or only the packages
> inside the team, that >would be great.
>
>
> awesome, you are now DM for t50, please do source-only uploads, and give
> me good packages if you want DM permissions for something else
> (I have to sponsor each package once for you before granting them, sorry!)
>
> please let me know :)
> (feel free to revert if you don't like them :) )
>
> thanks!
>
> G.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.alioth.debian.org/pipermail/pkg-security-team/attachments/20161018/8d574a31/attachment.html>


More information about the Pkg-security-team mailing list