[Pkg-shadow-devel] Bug#293492: useradd: by default creates user with unspecified shell, this causes problems

Alexander Gattin arg@online.com.ua
Thu, 12 May 2005 01:42:13 +0300


Hi!
On Wed, May 11, 2005 at 09:32:19PM +0200, Martin Quinson wrote:
> On Tue, May 10, 2005 at 12:05:28AM +0300, Alexander Gattin wrote:
> > The reason is empty initial value for def_shell _and_
> > absense of "SHELL=blahblahblah" line in the
> > /etc/default/useradd file. This file simply does not
> > exist on typical Debian system.
> 
> [...]
> 
> > Maybe we should just distribute a reasonable
> > /etc/default/useradd [config] file with passwd?
> 
> Why couldn't we just set a non-empty initial value to def_shell?

Only because this requres patching TFS while adding
/etc/defaults/useradd doesn't.

> It's easy to do,

yes

> and less intrusive that adding yet another file in /etc.

I'm not sure that it's less intrusive.

My proposal goes _along_ the upstream way to do things,
while another patch should first be decided whether to
come into 3xx or 4xx series. ;)

P.S. there's one good news for you: patching useradd.c
does still (at least) allow to add users with empty
shells with e.g. `useradd noshelluser -s ""` ;)

So the patch doesn't restrict useradd's user in any way
:))) 

-- 
WBR,
xrgtn