log4shib and pkg-config

[Cantor, Scott]

> Would you consider incorporating such changes into xmltooling,
> opensaml2 and shibboleth-sp2?

Eventually, but I'm too close to release right now and don't have time to go back and test this (care to guess how Solaris will handle it? I'll give you a hint...). Please go ahead and file issues for it and I'll get back to it.

> Should the Autoconf tests involve actual
> builds, like your current solution via log4shib-config?

That's always better than assuming things in my experience, but I don't know these new macros or how reliable they are.

> Anything else you'd prefer to have some other way?  It would be possible to eliminate
> XMLTOOLING_LOG4SHIB and friends, or to keep changing CFLAGS and LIBS
> instead of augmenting them where necessary, or to hide the log4shib/
> log4cpp duality into further defines/variables.

I don't know how I could eliminate the define since the headers are simply different in the two cases, but maybe I don't know what you're suggesting.

I see the difference there with the flags. I suppose that is better at the end of the day since it eliminates the need to track flags separately in configure for different dependency sets.

-- Scott