[Pkg-sql-ledger-discussion] Re: SQL-Ledger dpatch

[Raphael Hertzog]

Hi Dieter,

I'm cccing the maintenance list to share your remarks and ask for input 
on how to handle the various things.

On Sun, 08 Jan 2006, Dieter Simader wrote:
> 40imagepath.dpatch
> 	sql-ledger.gif was only used because some browsers, especially the
> ones on handhelds do not know how to display a .png file.

Actually, the main purpose of this patch is probably to change the path of
the pictures, so that it's possible to have the "images" directory placed
somewhere else. Currently the Debian package ships the images in
/usr/share/sql-ledger/ and the perl stuff in /usr/lib/sql-ledger/ (and the
apache configuration has an alias to point "sql-ledger/images" to the
right place).

This makes sense only IF we have architecture-dependant data in
/usr/lib/sql-ledger/ but AFAIK we don't have any such file, do we ?

So my suggestion is to place everything belowe /usr/share/sql-ledger/
and stop using that patch. 

> 10makefiles.dpatch
> @@ -0,0 +1,18 @@
> +PACKAGE = sql-ledger
> +
> +# Assumption: only the menu.pl differs between each directory
> 
> 	symlinks have been abondand, either hardlink or pull in the actual
> files from the tarball

Is there a reason for that ?

Dpkg can handle hardlinks so we can switch to hardlink. But I still would
like to know why this is needed.

> @@ -0,0 +1,13 @@
> +PACKAGE = sql-ledger
> +
> +FILES	= README Makefile faq.html
> 
> 	take all the files in the doc directory

Will do, except COPYRIGHT and COPYING since Debian provides its own
"copyright" file listing the upstream author(s) and the associated license
(pointing back to /usr/share/common-license/GPL to avoid having hundreds
of GPL copy on the system);

> @@ -0,0 +1,14 @@
> +PACKAGE = sql-ledger
> +
> +FILES	= *.html *.tex *.txt
> 
> 	other files may come yet, i.e .xml For now it is safe to assume
> there are no others.

Ok.

> @@ -0,0 +1,13 @@
> +PACKAGE = sql-ledger
> +
> +FILES	= sql-ledger.css
> 
> 	there are some more stylesheets now too

Updated the patch to include them. Thanks, I didn't notify that we missed
some.

> I realize the Makefile is for v2.2.6 so you may have changed all of this
> already.

The patch is quite old but it has been hand-edited since to fit some of
the changes but as you've just seen, we have missed some.

Thanks for reviewing them ! Do you plan to include a Makefile system in
the .tar.gz one day ? This would avoid thoses problems since you would
maintain the Makefile perfectly knowing what you do.

If you're interested, we can eventually try to work out a better patch
(here the Makefile are minimalistic and only suited for Debian), maybe
with a ./configure like system ?
 
> If you have any questions please don't hesitate to contact me.

We will do ! Thanks for the help.

Regards,
-- 
Raphaël Hertzog

Premier livre français sur Debian GNU/Linux :
http://www.ouaza.com/livre/admin-debian/