[Pkg-utopia-maintainers] Bug#833527: firewalld: Keep service lists sorted to make it easier to spot changes?

Petter Reinholdtsen pere at hungry.com
Fri Aug 5 13:04:49 UTC 2016


Package: firewalld
Version: 0.4.3.2-1
Severity: minor

I noticed this on the FreedomBox, where etckeeper store every change in
/etc/ in git.  After configuring Tor on the test machine, 'git diff'
show this set of changes to the /etc/firewalld/zones/external.xml file:

diff --git a/firewalld/zones/external.xml b/firewalld/zones/external.xml
index 73c852a..99911e8 100644
--- a/firewalld/zones/external.xml
+++ b/firewalld/zones/external.xml
@@ -2,11 +2,14 @@
 <zone>
   <short>External</short>
   <description>For use on external networks. You do not trust the other comput
ers on networks to not harm your computer. Only selected incoming connections a
re accepted.</description>
-  <service name="xmpp-server"/>
-  <service name="https"/>
   <service name="http"/>
+  <service name="tor-obfs3"/>
+  <service name="tor-obfs4"/>
+  <service name="https"/>
   <service name="xmpp-bosh"/>
   <service name="xmpp-client"/>
+  <service name="tor-orport"/>
+  <service name="xmpp-server"/>
   <service name="ssh"/>
   <masquerade/>
 </zone>

It is harder than it had to be to notice what was added and figuring out
which services were only moved in the list.  Please change firewalld to
keep the content of its files sorted, to make it possible for etckeeper
to only report changes to the files.

-- 
Happy hacking
Petter Reinholdtsen



More information about the Pkg-utopia-maintainers mailing list