[Pkg-utopia-maintainers] Bug#846245: Bug#846245: X-Cinnamon should be in the OnlyShownIn field of polkit-gnome-authentication-agent-1.desktop

[Michael Biebl]

Am 08.12.2016 um 20:57 schrieb Margarita Manterola:
> To recap what happened:
> 
> 0. For some reason that I can't really explain (laziness on our side), instead
> of using the desktop file shipped in the policykit-1-gnome package, Cinnamon was
> shipping it's own desktop file, *pointing to the file shipped by
> policykit-1-gnome*, but stating "OnlyShownIn=X-Cinnamon".
> 
> https://sources.debian.net/src/cinnamon/3.0.7-3/debian/patches/add_policykit-1-gnome_to_session/
> 
> 1. policykit-1-gnome changed the path of the binary.
> 
> This already broke in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=842184,
> because the desktop file was not updated then.
> 
> 2. All policykit support broke in cinnamon, until we updated the file with the
> new path.
> 
> This happened because of that external desktop file, that should have never
> been. So, can we fix that?
> 
> The necessary change is to add X-Cinnamon to the desktop file. After that, we
> can stop shipping the unnecessary additional desktop file, and we can use the
> one shipped by policykit-1-gnome in the session initialization.
> 
> BTW, the description of the package says that Cinnamon has its own
> implementation, which is not correct, so that would need to get updated as well.
> 
> Please let us (the cinnamon team) know when you are doing the upload, so that we
> can upload the changed package closely afterwards.

So, the first change of the path happened by accident, when I bumped the
debhelper compat level to 8. It changed from
/usr/lib/<pkgname> to /usr/lib/<multiarch>

Simon made a follow-up upload and changed it to /usr/lib. I would have
preferred if it was changed back to /usr/lib/<pkgname>.
One reason is, that I don't like executable directly in $libdir, the
other is, that I wanted to avoid unnecessary churn and last, it's
inconsistent with other packages I maintain.

So, I'm inclined to make (yet) another upload to put the binary back to
/usr/lib/<pkgname> and also adding

-OnlyShowIn=XFCE;Unity;
+OnlyShowIn=XFCE;Unity;X-Cinnamon;

Does that look correct (expecially the X- prefix) and is this what you
would prefer?



-- 
Why is it that all of the instruments seeking intelligent life in the
universe are pointed away from Earth?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-utopia-maintainers/attachments/20161209/47bb8a2b/attachment.sig>