cmake support: comments

[James Vega]

On Wed, Mar 29, 2006 at 04:12:41PM -0500, Stefano Zacchiroli wrote:
> On Wed, Mar 29, 2006 at 08:27:05PM +0000, James Vega wrote:
> > Added: trunk/vim7/patches/161_cmake-support.diff
> <snip>
> > ++"   Copyright (c) 2002 Kitware, Inc., Insight Consortium.  All rights reserved.
> > ++"   See Copyright.txt or http://www.cmake.org/HTML/Copyright.html for details.
> 
> Two comments on this:
> 1) have you forwarded it to Bram for inclusion?

No, I haven't as I didn't want to be the maintainer for the file.
Someone could email the author of the file to see if they would send it
to Bram and keep him up to date with any changes.

>    Having seen how painful
>    is to mass pushing patches upstream before a release I would like to
>    do it piecewise in the future :-)

Agreed.  That was one thing I noticed when I joined the pkg-vim team and
would like to keep the number of patches we maintain as minimal as
possible.  :)  This may not be as easy as we'd like though since many of
the patches are not bug fixes, but feature enhancements which Bram
doesn't accept into stable releases.

> 2) even if they copyright reported in Copyright.txt is (or better seems
>    at first glance since I have not investigated thoroughly) DFSG free,
>    the sentence "All rights reserved" sounds very non-free to me.

That's pretty common and from what I can see their license is DFSG free.
It might be worthwhile checking debian-legal for any discussion about
the "All rights reserved" phrase, though.

>    What
>    about including there Copyright.txt verbatim? After all I don't think
>    we ship it at all ...

Yes, we should do this.  It just wasn't part of the patch I was copying
over from the vim6 branch.

> Thanks for the porting work to the vim7 branch!
> Cheers.

You're welcome.  :)  Should we make another 6.4 release while we're
waiting for vim7?  I'm inclined to say no since I think vim7 will be
coming out relatively soon.

James
-- 
GPG Key: 1024D/61326D40 2003-09-02 James Vega <jamessan at jamessan.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 199 bytes
Desc: Digital signature
Url : http://lists.alioth.debian.org/pipermail/pkg-vim-maintainers/attachments/20060329/343a3ba2/attachment-0001.pgp