Bug#983985: bctoolbox: ftbfs with GCC-11

[Matthias Klose]

Package: src:bctoolbox
Version: 4.4.13-2
Severity: normal
Tags: sid bookworm
User: debian-gcc at lists.debian.org
Usertags: ftbfs-gcc-11

[This bug is not targeted to the upcoming bullseye release]

Please keep this issue open in the bug tracker for the package it
was filed for.  If a fix in another package is required, please
file a bug for the other package (or clone), and add a block in this
package. Please keep the issue open until the package can be built in
a follow-up test rebuild.

The package fails to build in a test rebuild on at least amd64 with
gcc-11/g++-11, but succeeds to build with gcc-10/g++-10. The
severity of this report will be raised before the bookworm release,
so nothing has to be done for the bullseye release.

The full build log can be found at:
http://people.debian.org/~doko/logs/20210228/filtered/gcc11/bctoolbox_4.4.13-2_unstable_gcc11.log
The last lines of the build log are at the end of this report.

To build with GCC 11, either set CC=gcc-11 CXX=g++-11 explicitly,
or install the gcc, g++, gfortran, ... packages from experimental.

  apt-get -t=experimental install g++ 

Common build failures are new warnings resulting in build failures with
-Werror turned on, or new/dropped symbols in Debian symbols files.
For other C/C++ related build failures see the porting guide at
http://gcc.gnu.org/gcc-11/porting_to.html

GCC 11 defaults to the GNU++17 standard.  If your package installs
header files in /usr/include, please don't work around C++17 issues
by choosing a lower C++ standard for the package build, but fix these
issues to build with the C++17 standard.

[...]
 1071 |                 const uint8_t *IV,
      |                 ~~~~~~~~~~~~~~~^~
/<<PKGBUILDDIR>>/src/crypto/mbedtls.c:1797:43: error: argument 1 of type ‘const uint8_t[16]’ {aka ‘const unsigned char[16]’} with mismatched bound [-Werror=array-parameter=]
 1797 | void bctbx_aes128CfbDecrypt(const uint8_t key[16],
      |                             ~~~~~~~~~~~~~~^~~~~~~
In file included from /<<PKGBUILDDIR>>/src/crypto/mbedtls.c:48:
/<<PKGBUILDDIR>>/include/bctoolbox/crypto.h:1087:57: note: previously declared as ‘const uint8_t *’ {aka ‘const unsigned char *’}
 1087 | BCTBX_PUBLIC void bctbx_aes128CfbDecrypt(const uint8_t *key,
      |                                          ~~~~~~~~~~~~~~~^~~
/<<PKGBUILDDIR>>/src/crypto/mbedtls.c:1798:31: error: argument 2 of type ‘const uint8_t[16]’ {aka ‘const unsigned char[16]’} with mismatched bound [-Werror=array-parameter=]
 1798 |                 const uint8_t IV[16],
      |                 ~~~~~~~~~~~~~~^~~~~~
In file included from /<<PKGBUILDDIR>>/src/crypto/mbedtls.c:48:
/<<PKGBUILDDIR>>/include/bctoolbox/crypto.h:1088:32: note: previously declared as ‘const uint8_t *’ {aka ‘const unsigned char *’}
 1088 |                 const uint8_t *IV,
      |                 ~~~~~~~~~~~~~~~^~
/<<PKGBUILDDIR>>/src/crypto/mbedtls.c:1829:43: error: argument 1 of type ‘const uint8_t[32]’ {aka ‘const unsigned char[32]’} with mismatched bound [-Werror=array-parameter=]
 1829 | void bctbx_aes256CfbEncrypt(const uint8_t key[32],
      |                             ~~~~~~~~~~~~~~^~~~~~~
In file included from /<<PKGBUILDDIR>>/src/crypto/mbedtls.c:48:
/<<PKGBUILDDIR>>/include/bctoolbox/crypto.h:1104:57: note: previously declared as ‘const uint8_t *’ {aka ‘const unsigned char *’}
 1104 | BCTBX_PUBLIC void bctbx_aes256CfbEncrypt(const uint8_t *key,
      |                                          ~~~~~~~~~~~~~~~^~~
/<<PKGBUILDDIR>>/src/crypto/mbedtls.c:1830:31: error: argument 2 of type ‘const uint8_t[16]’ {aka ‘const unsigned char[16]’} with mismatched bound [-Werror=array-parameter=]
 1830 |                 const uint8_t IV[16],
      |                 ~~~~~~~~~~~~~~^~~~~~
In file included from /<<PKGBUILDDIR>>/src/crypto/mbedtls.c:48:
/<<PKGBUILDDIR>>/include/bctoolbox/crypto.h:1105:32: note: previously declared as ‘const uint8_t *’ {aka ‘const unsigned char *’}
 1105 |                 const uint8_t *IV,
      |                 ~~~~~~~~~~~~~~~^~
/<<PKGBUILDDIR>>/src/crypto/mbedtls.c:1858:43: error: argument 1 of type ‘const uint8_t[32]’ {aka ‘const unsigned char[32]’} with mismatched bound [-Werror=array-parameter=]
 1858 | void bctbx_aes256CfbDecrypt(const uint8_t key[32],
      |                             ~~~~~~~~~~~~~~^~~~~~~
In file included from /<<PKGBUILDDIR>>/src/crypto/mbedtls.c:48:
/<<PKGBUILDDIR>>/include/bctoolbox/crypto.h:1121:57: note: previously declared as ‘const uint8_t *’ {aka ‘const unsigned char *’}
 1121 | BCTBX_PUBLIC void bctbx_aes256CfbDecrypt(const uint8_t *key,
      |                                          ~~~~~~~~~~~~~~~^~~
/<<PKGBUILDDIR>>/src/crypto/mbedtls.c:1859:31: error: argument 2 of type ‘const uint8_t[16]’ {aka ‘const unsigned char[16]’} with mismatched bound [-Werror=array-parameter=]
 1859 |                 const uint8_t IV[16],
      |                 ~~~~~~~~~~~~~~^~~~~~
In file included from /<<PKGBUILDDIR>>/src/crypto/mbedtls.c:48:
/<<PKGBUILDDIR>>/include/bctoolbox/crypto.h:1122:32: note: previously declared as ‘const uint8_t *’ {aka ‘const unsigned char *’}
 1122 |                 const uint8_t *IV,
      |                 ~~~~~~~~~~~~~~~^~
cc1: all warnings being treated as errors
make[3]: *** [src/CMakeFiles/bctoolbox-static.dir/build.make:124: src/CMakeFiles/bctoolbox-static.dir/utils/port.c.o] Error 1
make[3]: *** Waiting for unfinished jobs....
make[3]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
make[2]: *** [CMakeFiles/Makefile2:139: src/CMakeFiles/bctoolbox.dir/all] Error 2
make[2]: *** Waiting for unfinished jobs....
/<<PKGBUILDDIR>>/src/crypto/mbedtls.c: In function ‘bctbx_sha384’:
/<<PKGBUILDDIR>>/src/crypto/mbedtls.c:1513:9: error: ‘mbedtls_sha512’ accessing 64 bytes in a region of size 48 [-Werror=stringop-overflow=]
 1513 |         mbedtls_sha512(input, inputLength, hashOutput, 1); /* last param to one to select SHA384 and not SHA512 */
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/<<PKGBUILDDIR>>/src/crypto/mbedtls.c:1513:9: note: referencing argument 3 of type ‘unsigned char *’
In file included from /usr/include/mbedtls/entropy.h:61,
                 from /<<PKGBUILDDIR>>/src/crypto/mbedtls.c:34:
/usr/include/mbedtls/sha512.h:302:25: note: in a call to function ‘mbedtls_sha512’
  302 | MBEDTLS_DEPRECATED void mbedtls_sha512( const unsigned char *input,
      |                         ^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[3]: *** [src/CMakeFiles/bctoolbox-static.dir/build.make:176: src/CMakeFiles/bctoolbox-static.dir/crypto/mbedtls.c.o] Error 1
make[3]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
make[2]: *** [CMakeFiles/Makefile2:166: src/CMakeFiles/bctoolbox-static.dir/all] Error 2
make[2]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
make[1]: *** [Makefile:152: all] Error 2
make[1]: Leaving directory '/<<PKGBUILDDIR>>/obj-x86_64-linux-gnu'
dh_auto_build: error: cd obj-x86_64-linux-gnu && make -j4 "INSTALL=install --strip-program=true" VERBOSE=1 returned exit code 2
make: *** [debian/rules:8: binary] Error 25
dpkg-buildpackage: error: fakeroot debian/rules binary subprocess returned exit status 2