[Pkg-wpa-devel] Bug#353530: Several package enhancements, fixing some flaws in maintainer scripts

[Kel Modderman]

Package: wpasupplicant
Version: 0.4.7-3

The following lintian report shows some quire serious problems:-

Now running lintian...
dpkg-source: warning: extracting unsigned source package (./dsc)
E: wpasupplicant: duplicate-updaterc.d-calls-in-postinst wpasupplicant
E: wpasupplicant: duplicate-updaterc.d-calls-in-postrm wpasupplicant
E: wpasupplicant: duplicate-conffile /etc/init.d/wpasupplicant
E: wpasupplicant: duplicate-conffile /etc/default/wpasupplicant
E: wpasupplicant: duplicate-conffile /etc/wpa_supplicant.conf
W: wpasupplicant: wrong-name-for-upstream-changelog usr/share/doc/wpasupplicant/ChangeLog.gz
Finished running lintian.

Upon inspecting the source package I also noticed a few other things that could be improved. Attached is a series of patches to address each issue that will be briefly described below:-

00_debian-changelog.patch

The changelog entry briefly describing the following changes


01_use-upstream-manpages.patch

Remove debian manpages and used those that are (well) maintained upstream. No need to duplicate efforts here imho.


02_wpagui-manpage-man8.patch

Install wpa_gui manpage to man8, as it is an administration tool. The other manpages also live here.


03_cleanup-install-target.patch

Eliminate double handling of the binary installation. Don't use debian/tmp or *.install files. Install binaries directly into their respective package staging directory tree via existing debian/rules commands.


04_precise-qmake-cmd.patch

Explicitly define qmake-qt4 as the $(QMAKE) var. Fails to build on systems with previous/parallel qt installations.


05_let-debhelper4-mark-conffiles.patch

The debhelper compat level used marks conffiles automatically.


06_let-dh_installinit-create-postrm.patch

The current postrm file contains the #DEBHELPER# token, which is automatically replaced by the _exact_ same code in the rest of the script by dh_installinit. This is not good.


07_dh_installinit-postinst-cleanup.patch

Set the update-rc.d options in debian/rules. Also eliminate duplication of code automatically injected by dh_installinit.


08_install-upstream-changelog-correctly.patch

Use debian/rules to correctly install the upstream changelog.


09_add-watch-file.patch

Add a watch file to assist in tracking new upstream releases.


Thanks, Kel.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 00_debian-changelog.patch
Type: text/x-patch
Size: 1409 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-wpa-devel/attachments/20060219/70a1bf11/00_debian-changelog-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 01_use-upstream-manpages.patch
Type: text/x-patch
Size: 4508 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-wpa-devel/attachments/20060219/70a1bf11/01_use-upstream-manpages-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 02_wpagui-manpage-man8.patch
Type: text/x-patch
Size: 2348 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-wpa-devel/attachments/20060219/70a1bf11/02_wpagui-manpage-man8-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 03_cleanup-install-target.patch
Type: text/x-patch
Size: 1529 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-wpa-devel/attachments/20060219/70a1bf11/03_cleanup-install-target-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 04_precise-qmake-cmd.patch
Type: text/x-patch
Size: 398 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-wpa-devel/attachments/20060219/70a1bf11/04_precise-qmake-cmd-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 05_let-debhelper4-mark-conffiles.patch
Type: text/x-patch
Size: 401 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-wpa-devel/attachments/20060219/70a1bf11/05_let-debhelper4-mark-conffiles-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 06_let-dh_installinit-create-postrm.patch
Type: text/x-patch
Size: 458 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-wpa-devel/attachments/20060219/70a1bf11/06_let-dh_installinit-create-postrm-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 07_dh_installinit-postinst-cleanup.patch
Type: text/x-patch
Size: 1497 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-wpa-devel/attachments/20060219/70a1bf11/07_dh_installinit-postinst-cleanup-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 08_install-upstream-changelog-correctly.patch
Type: text/x-patch
Size: 763 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-wpa-devel/attachments/20060219/70a1bf11/08_install-upstream-changelog-correctly-0001.bin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 09_add-watch-file.patch
Type: text/x-patch
Size: 330 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-wpa-devel/attachments/20060219/70a1bf11/09_add-watch-file-0001.bin