[Pkg-xen-devel] Bug#655301: Bug#655301: Bug#655301: Bug#655301: Bug#655301: Bug#655301: xcp-xapi fails to start

Ian Campbell ijc at hellion.org.uk
Wed Jan 18 07:20:05 UTC 2012


On Wed, 2012-01-18 at 13:05 +0800, Thomas Goirand wrote:

> Overwriting the /etc/default/xen file did *NOT* overwrite a local change
> in the *value* stored in the file. It would have only overwrite things
> like comments, but keep the value written in the "TOOLSTACK" variable
> (well, only if it has one of the 3 valid values, but do we care keeping
> a broken value?). I believe doing this way is also Debian policy
> compliant, there's nothing in the policy that forces you to keep
> administrator's comments in a configuration file.

Rubbish, policy quite clearly says, WRT configuration files:
        local changes must be preserved during a package upgrade
        
It makes no distinction about "values" or "comments" or any other sort
of change.

Maybe the comments are actually important to the administrator? Why else
would he have added them.
 
Anyway, you don't know what else an administrator has added to that
file. Perhaps they have added their own variables to support their
modifications to the initscripts? Perhaps they have locally added a
fourth option for $TOOLSTACK to support their own use cases?

>  If you think I'm wrong, let me know.

You are wrong.

> Anyway, I am still waiting for comments on how you or Bastian want this
> to be done. I have nothing against grep and friends...

Can't ucf be used for this? (e.g. generate a $TMP, or /var?, version of
the file and use ucf to handle the update).

Ian.

-- 
Ian Campbell


Satire is what closes in New Haven.






More information about the Pkg-xen-devel mailing list