[Pkg-xfce-commits] [Git][xfce-team/desktop/xfwm4][debian/master] 2 commits: Add patch to fix client: Handle removal of GTK_FRAME_EXTENTS. (Closes: #1000841)

[Mateusz Łukasik (@mati75-guest)]

Mateusz Łukasik pushed to branch debian/master at xfce / desktop / xfwm4


Commits:
359bf2d4 by Mateusz Łukasik at 2022-01-13T20:32:30+01:00
Add patch to fix client: Handle removal of GTK_FRAME_EXTENTS. (Closes: #1000841)

- - - - -
33c1bcf4 by Mateusz Łukasik at 2022-01-13T20:33:20+01:00
 d/control: update standards version to 4.6.0.

- - - - -


4 changed files:

- debian/changelog
- debian/control
- + debian/patches/client_Handle_removal_of_GTK_FRAME_EXTENTS.patch
- + debian/patches/series


Changes:

=====================================
debian/changelog
=====================================
@@ -1,3 +1,12 @@
+xfwm4 (4.16.1-2) UNRELEASED; urgency=medium
+
+  * Team upload.
+  * Add patch to fix client: Handle removal of GTK_FRAME_EXTENTS.
+    (Closes: #1000841)
+  * d/control: update standards version to 4.6.0.
+
+ -- Mateusz Łukasik <mati75 at linuxmint.pl>  Thu, 13 Jan 2022 20:31:26 +0100
+
 xfwm4 (4.16.1-1) unstable; urgency=medium
 
   * New upstream version 4.16.1


=====================================
debian/control
=====================================
@@ -23,7 +23,7 @@ Build-Depends: debhelper-compat (= 12),
                x11proto-present-dev,
                xfce4-dev-tools (>= 4.16)
 Rules-Requires-Root: no
-Standards-Version: 4.5.1
+Standards-Version: 4.6.0
 Homepage: https://docs.xfce.org/xfce/xfwm4/start
 Vcs-Git: https://salsa.debian.org/xfce-team/desktop/xfwm4.git
 Vcs-Browser: https://salsa.debian.org/xfce-team/desktop/xfwm4


=====================================
debian/patches/client_Handle_removal_of_GTK_FRAME_EXTENTS.patch
=====================================
@@ -0,0 +1,56 @@
+From 488288f6e35d5d3dc077e87fe2ed83129692f62e Mon Sep 17 00:00:00 2001
+From: Olivier Fourdan <fourdan at xfce.org>
+Date: Sun, 14 Nov 2021 11:00:55 +0100
+Subject: [PATCH] client: Handle removal of GTK_FRAME_EXTENTS
+
+Chromium and GOOGLE Chrome have now support for GTK_FRAME_EXTENTS.
+
+When maximizing a window, Chromium/Chrome simply removes the property
+on its toplevel rather than setting all values to 0.
+
+xfwm4 would simply ignore the property change because it could not read
+the values and therefore apply the old, wrong values.
+
+Fix xfwm4 to handle the property removal like an actual property change
+to 0.
+
+Signed-off-by: Olivier Fourdan <fourdan at xfce.org>
+Closes: https://gitlab.xfce.org/xfce/xfwm4/-/issues/603
+---
+ src/client.c | 6 ++++++
+ 1 file changed, 6 insertions(+)
+
+diff --git a/src/client.c b/src/client.c
+index 4e6affcfd..310cf90aa 100644
+--- a/src/client.c
++++ b/src/client.c
+@@ -4200,6 +4200,7 @@ clientGetGtkFrameExtents (Client * c)
+     DisplayInfo *display_info;
+     gboolean value_changed = FALSE;
+     gulong *extents;
++    unsigned long old_value;
+     int nitems;
+     int i;
+ 
+@@ -4209,6 +4210,8 @@ clientGetGtkFrameExtents (Client * c)
+     screen_info = c->screen_info;
+     display_info = screen_info->display_info;
+     extents = NULL;
++
++    old_value = FLAG_TEST (c->flags, CLIENT_FLAG_HAS_FRAME_EXTENTS);
+     FLAG_UNSET (c->flags, CLIENT_FLAG_HAS_FRAME_EXTENTS);
+ 
+     if (getCardinalList (display_info, c->window, GTK_FRAME_EXTENTS, &extents, &nitems))
+@@ -4232,6 +4235,9 @@ clientGetGtkFrameExtents (Client * c)
+         XFree (extents);
+     }
+ 
++    /* Adding or removing the property also counts as a change */
++    value_changed |= (old_value ^ FLAG_TEST (c->flags, CLIENT_FLAG_HAS_FRAME_EXTENTS));
++
+     return value_changed;
+ }
+ 
+-- 
+GitLab
+


=====================================
debian/patches/series
=====================================
@@ -0,0 +1 @@
+client_Handle_removal_of_GTK_FRAME_EXTENTS.patch



View it on GitLab: https://salsa.debian.org/xfce-team/desktop/xfwm4/-/compare/9421988ada78bdb730a2517d682f575bc2dae17c...33c1bcf427658720c39cf0800bc9479bf9ed7313

-- 
View it on GitLab: https://salsa.debian.org/xfce-team/desktop/xfwm4/-/compare/9421988ada78bdb730a2517d682f575bc2dae17c...33c1bcf427658720c39cf0800bc9479bf9ed7313
You're receiving this email because of your account on salsa.debian.org.


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://alioth-lists.debian.net/pipermail/pkg-xfce-commits/attachments/20220113/dd4f8b4d/attachment-0001.htm>