Bug#312185: vorbis-tools: ogg123 plays speex files wrong: clicks, then silence.

[Martin Steghöfer]

Martin Steghöfer wrote:
> However, the issue happens even after transcoding the speex file to 
> ogg vorbis (using audacity).

This assessment was based and on a file mix-up in my testing process and 
is wrong. The issue is speex-specific.

The problem occurs with speex files that declare 2 channels in the 
header, but don't provide any in-band stereo signal before the first 
sample. As far as I can see, the speex standard allows this, it is never 
even mentioned that any in-band stereo signal has to be sent at all. So 
ogg123 should be able to handle this case.

However, the initialization of the stereo information data structure in 
ogg123 doesn't happen until the first in-band stereo signal is received. 
For all samples before the first stereo signal, the stereo information 
data structure is used in an uninitialized state and therefore produces 
distortions/noise/silence.

The patch in git commit fb82b1de29 fixes the problem by using the proper 
libspeex functions for handling the life cycle of the stereo information 
data structure.