Bug#771448: vorbistagedit doesn't read filenames from stdin

Martin Steghöfer martin at steghoefer.eu
Sat Nov 29 17:07:00 UTC 2014


Package: vorbis-tools
Version: 1.4.0-5
Severity: normal
File: /usr/bin/vorbistagedit

While working on the fix for #763338, related to the "vorbistagedit" 
script, I discovered another issue with the same script:

The documentation claims that without input files given as command-line 
arguments the list of input filenames is read from stdin, and indeed 
there is code in the script to do so. However, that code is never 
actually executed. If there are no input files given as command-line 
arguments, the "usage" error message is shown and the script quits.

I assume that the guard showing the "usage" information and exiting was 
introduced in order to avoid confusion for users that launch the script 
vorbistagedit without parameters and get a program that waits for input 
without saying anything. I worked around this confusion by adding an 
explanatory message in case that stdin comes from an interactive 
console. So the guard preventing input from stdin could be removed. The 
"usage" error message is only shown, if *after* reading from stdin the 
filename list is still empty.

The change is in git's master branch. Probably this isn't important 
enough to make it into Jessie, is it?

Cheers,
Martin



More information about the pkg-xiph-maint mailing list