[Pkg-zsh-devel] RFS: oh-my-zsh/0~20140211-1 [ITP]

[Axel Beckert]

Hi Jerome,

Jerome Charaoui wrote:
> Alright, it seems there wasn't a lot of changes needed to push this
> forward. I think the most important is that we won't put
> theme_chooser.sh in /usr/bin because themes have a wide range of
> dependencies (ie. git, svn, hg, virtualenv, etc.) and most themes (if
> not all) assume they are always available, which is bound to result in
> error messages as users cycle through all the themes. Hence,
> README.Debian won't refer to oh-my-zsh-theme-chooser and instead will
> offer the URL of the upstream wiki page that has screenshots of the
> available themes.

Fine for me.

> Here is the link for the updated mentors package :
> http://mentors.debian.net/debian/pool/main/o/oh-my-zsh/oh-my-zsh_0~20140211-1.dsc

I've found one not yet fixed and one new issue. Both should be easy to
fix, though.

Axel Beckert wrote:
> Missing licenses
> ================
[...]
> * plugins/git-prompt/gitstatus.py seems to have no license attached,
>   neither in the files nor at
>   https://github.com/olivierverdier/zsh-git-prompt but
>   seems to be not by Robby Russell, either.

For about three weeks there is now a license at
https://github.com/olivierverdier/zsh-git-prompt/blob/master/LICENSE.md

So that should be easy to fix, too.

> Nice to have
> ============
> 
> A minor issue, but potentially annoying: Reading Textile markup is not
> very comfortable IMHO, so instead of installing upstream's
> README.textile directly you may run it through pandoc first:
> 
>   pandoc -f textile -t plain README.textile > debian/oh-my-zsh/usr/share/doc/oh-my-zsh/README

Much better now.

You should also remove README.textile from debian/docs, because
currently it's installed in addition to the reformatted README.

> (Of course this would need a build-dependency on pandoc then.)

That one is missing. Hence the package doesn't build in a clean chroot
environment with just build-dependencies being installed.

		Regards, Axel
-- 
 ,''`.  |  Axel Beckert <abe at debian.org>, http://people.debian.org/~abe/
: :' :  |  Debian Developer, ftp.ch.debian.org Admin
`. `'   |  1024D: F067 EA27 26B9 C3FC 1486  202E C09E 1D89 9593 0EDE
  `-    |  4096R: 2517 B724 C5F6 CA99 5329  6E61 2FF9 CD59 6126 16B5
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-zsh-devel/attachments/20140921/f2c21971/attachment-0001.sig>