[Pkg-zsh-devel] zsh-syntax-highlighting 0.6.0~rc1-1 uploaded to mentors.debian.net

[Daniel Shahaf]

Axel Beckert wrote on Mon, Jul 31, 2017 at 23:15:53 +0200:
> Hi Daniel,
> 

Good morning Axel,

Thanks for the quick reply.

> Daniel Shahaf wrote:
> > mentors.debian.net wrote on Mon, 31 Jul 2017 20:36 +0000:
> > > Your upload of the package 'zsh-syntax-highlighting' to mentors.debian.net was
> > > successful. Others can now see it. The URL of your package is:
> > > https://mentors.debian.net/package/zsh-syntax-highlighting
> > > 
> > > The respective dsc file can be found at:
> > > https://mentors.debian.net/debian/pool/main/z/zsh-syntax-highlighting/zsh-syntax-highlighting_0.6.0~rc1-1.dsc
> > 
> > I've just uploaded a z-sy-h release candidate (for experimental) to mentors
> 
> Ah, now that's a good reason to get to my long-time open todo to look
> through your work for being able to give you upload permissions for
> zsh-syntax-highlighting with a clear conscience. :-)
> 
> The first thing I ran into was that I couldn't verify the GPG
> signature on the .dsc:
> 
> → gpg --keyring /usr/share/keyrings/debian-maintainers.gpg --verify zsh-syntax-highlighting_0.6.0~rc1-1.dsc
> gpg: Signature made Mon Jul 31 22:24:46 2017 CEST
> gpg:                using RSA key 6EB60B637CE5ACBF2449A2DADB27E997429AF20C
> gpg: Can't check signature: No public key
> 
> Reason is that while you updated your key wrt. to the expiry date on
> the usual public keyservers, the update seems not included in the
> debian-keyring package (yet):

I updated my key a couple of weeks ago (extended expiry + new subkey)
and uploaded it to keyring.d.o on the same day.

> > It was a little trickier than I'd expected since I had to do a minor
> > history surgery (details in the log messages),
> 
> Indeed sounds hairy. But looks well solved to me. I like the verbose
> commit message with the ascii-art-ish history tree.
> 

Verbose commit messages is a habit that was indoctrinated into me early on.

> > but anyway, I'm looking for volunteers to sponsor this.
> 
> Looks mostly fine.
> 
> Things which should be fixed before uploading:
> 
> W: zsh-syntax-highlighting: debian-changelog-line-too-long line 4
> 

I'll fix it.

I didn't get any lintian warnings in my build.  My builds used to run
lintian automatically; I'll restore that behaviour.

> Some comments about the remaining lintian warnings:
> 
> I: zsh-syntax-highlighting source: debian-rules-parses-dpkg-parsechangelog (line 20)
> I: zsh-syntax-highlighting source: debian-rules-parses-dpkg-parsechangelog (line 21)
> 
> Lintian is probably right, but that's nothing urgent at all IMHO.

Will fix.

For context, this only affects the "_origtar" target, which is run as
part of updating the package to a new upstream release but is not run as
part of generating a .dsc or a .deb.

> P: zsh-syntax-highlighting source: debian-watch-may-check-gpg-signature
> 
> Mostly target towards upstream, but since you're also upstream...
> I'd sponsor it without a fix for that, nevertheless. But you might
> want to look into that at some point in the future. :-)
> 

The upstream tag _is_ signed; the problem is just that debian/watch
doesn't check the signature.  Added to my list.

> Anyway, I hopefully managed to give you DM upload permissions for
> zsh-syntax-highlighting. (Sorry, it took so long.)

Thanks.  I received an ftp-master confirmation, I think your command
worked.

> You might need to update your key in the debian-maintainer keyring
> before uploading, though. If that's not possible soon-ish (IIRC it's
> not the package state which is relevant, but the current state on the
> Debian servers, but I'm not 100% sure), I can one more sponsor an
> upload.
> 

As I said, I already pushed my key to keyring.d.o.  I'll fix the line
length issue and try to upload rc1-2; if that fails, I'll circle back
and ask for a sponsored upload.

> I also assume that you don't actually want 0.6.0~rc1-1 to be uploaded
> but maybe 0.6.0-1 or so.

0.6.0-rc1 is an upstream release candidate so I assume it would make
sense to upload it to experimental.  (0.6.0-GA is expected soon after
zsh-5.4-GA; see upstream issue #412.)

Quick question: the process for uploading to experimental is just to put
"experimental" in d/changelog before uploading, right?  I.e., is the
dput(1) invocation is identical for unstable and experimental uploads?
(I've checked maint-guide and developers-reference.)

> At least I saw the start of 0.6.0~rc1-2 in git.

The 0.6.0~rc1-2 commit was just a standard "Bump the version number
after tagging" commit; I didn't have specific changes planned for -2.
(But now -2 will have the changelog line length fix.)

> (Just tell me if I'm wrong here. But then again, that overlong line
> should be fixed before uploading anyways.)

*nod*

Thanks for the detailed review.

Cheers,

Daniel