[Reproducible-builds] Bug#813052: Bug#813052: Bug#813052: diffoscope takes more than an hour on foreign arch libc6

[Jérémy Bobbio]

Hi Helmut,

Helmut Grohne:
> On Fri, Jan 29, 2016 at 03:11:55PM +0100, Jérémy Bobbio wrote:
> > Helmut Grohne:
> > > Even though I cannot reproduce the issue at hand, I think that the code
> > > adding automatic debug symbols looks fishy to me. It appears to recurse
> > > over /tmp here and that looks very wrong to me.
> > 
> > I don't understand what you mean by that. Could you provide be (at least
> > some) of the `--debug` output?
> 
> What I mean is that diffoscope takes the directory that contains the
> first debian package and then recursively looks at all contained files.
> If that tree happens to be big, bad things can happen.

diffoscope will try to locate a package with matching debug symbols when
it's comparing ELF files inside two .deb. It will indeed look at the
files in the parent container (in your case a directory), but it's only
a quick look: looking for .deb files and looking at the control file.

Still, it was indeed looking at all files in the tree. Could you try the
attached patch and see if it helps?

-- 
Lunar                                .''`. 
lunar at debian.org                    : :Ⓐ  :  # apt-get install anarchism
                                    `. `'` 
                                      `-   
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Use-recursive-containers-for-directory.patch
Type: text/x-diff
Size: 2843 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20160205/96906be3/attachment.patch>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20160205/96906be3/attachment.sig>