Bug#837681: Workaround

Peter Oberndorfer kumbayo84 at arcor.de
Thu Jul 27 11:09:42 UTC 2017


The attached patch should help the comparison to continue instead of crashing.

A few points are still open/unclear for me:
* When FsImageContainer.open_archive returns None, the rest of the code still thinks there are files to extract
  and calls get_member_names? Is this OK? Should i behave more like if an exception was raised?
* Is it OK that the extracting error shows up in the HTML output?
* Should we create a test for missing guestfs and guestfs launch failed?
* Should we tell the user about the possibility that unreadable kernels under /boot can cause this problem?
  And should this information be included in the HTML output or only in the log outupt
* Is it possible to have a mechanism like @tool_required or raise RequiredToolNotFound for missing python modules like "guestfs"
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Better-handle-errors-in-FsImageContainer.open_archiv.patch
Type: text/x-patch
Size: 3490 bytes
Desc: not available
URL: <http://lists.alioth.debian.org/pipermail/reproducible-builds/attachments/20170727/f93d2d4b/attachment.bin>


More information about the Reproducible-builds mailing list