[sane-devel] [sane-commit] CVS update of sane-backends/frontend (saned.c)

[m. allan noah]

On Thu, Mar 12, 2009 at 2:52 PM, Julien BLACHE <jb at jblache.org> wrote:
> Ilia Sotnikov <hostcc at gmail.com> wrote:
>
> Hi,
>
>>> Please detail your change, and how it alters the behaviour of
>>> check_host().
>>
>> Just as simple as it sounds - if the name lookup with local hostname
>> failed, continue to check remote host (assuming that remote host
>> address isn't the same as local one) rather then denied access for it.
>> The name lookup could fail for obvious reasons - the local host isn't
>> registered on DNS server participating in the process, or no DNS
>> servers are configured (this I need to re-check).
>
> gethostbyname() includes information from /etc/hosts, so that lookup
> should not fail on any properly-configured system.
>
> Please revert.

I'll agree with Ilia on this one- If you have dhcp enabled, your local
IP might not be in /etc/hosts, and you might not have a local dns
server that knows about your RFC-1918 addresses.

allan

-- 
"The truth is an offense, but not a sin"