[3dprinter-general] Bug#706656: ITP: cura -- Controller for 3D printers

[Gregor Riepl]

> You set the Debian Fonts Task Force as the maintainer.  That seems reasonable,
> but they should know about this: did you check with them that they will indeed
> maintain the package?  (Since you're set as uploader, you'll probably still be
> doing it, but you're doing it in their name, so they should agree to it.)

My bad, I copy-pasted that and didn't know what to do with it.
I'll contact them ASAP.

> The description feels like a marketing snippet with all the brand names.  That
> information is better placed in debian/copyright.  Users reading the
> description want to know what the package does and if they want to install it,
> not who made it or paid for it.  It's not always wrong to mention brands, and
> in this case you could mention Google if you think people might be looking for
> "that font from Google".

Does this look better?

 Open Sans is a clean and modern sans-serif typeface designed
 by Steve Matteson and commissioned by Google.
 .
 This version contains the complete 897 character set, which includes
 the standard ISO Latin 1, Latin CE, Greek and Cyrillic character sets.
 .
 Open Sans was designed with an upright stress, open forms and a neutral,
 yet friendly appearance. It was optimized for print, web, and mobile
 interfaces, and has excellent legibility characteristics in its letterforms.
 .
 Both condensed and non-condensed typefaces are included with this package.

Even if it doesn't seem very neutral, it's a good description of the font, its
targeted usage and its look. Isn't that what users want to see?

> You list unzip as a Build-Depends, but it's only needed for get-orig-source.  I
> don't think this is reason for a Build-Depends, but wasn't sure, so I checked
> some documents.  I didn't find much; the only thing I see is our policy manual,
> section 7.7, which says what should be in Build-Depends and it doesn't mention
> the get-orig-source target at all.  It also doesn't say anything about "extra"
> dependencies.  In 4.2, in particular footnote 14, it does say that you should
> only list packages that you use directly, but it doesn't say if optional
> targets are reasons for listing packages.  I think it's useful for users to be
> able to run get-orig-source without manually figuring out the dependencies, but
> if someone knows about different rules or conventions in Debian, please speak
> up.

All right, get-orig-source was a bit of mystery to me anyway.
It looks like it works well with uscan, but uscan seems useless if you don't
have a watch file.
I'll remove the dependency.

>> And the updated packages are on Debian mentors now:
>> https://mentors.debian.net/packages/uploader/onitake%40gmail.com
> 
> I'll look at them later today.

I already noticed a potential problem - mentors warns that the watch file
doesn't work, but I don't see any errors. Strange.
Maybe some local testing is in order.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/3dprinter-general/attachments/20170329/983bdf38/attachment.sig>