[buildd-tools-devel] Bug#551311: Bug#551311: Updated patches for debuild like functionality in sbuild.

[Andres Mejia]

On Friday 11 December 2009 07:17:04 Roger Leigh wrote:
> On Thu, Dec 10, 2009 at 09:38:08PM -0500, Andres Mejia wrote:
> > First I would like to say, thank you for reviewing my patches. :)
> >
> > Next I would like to say, please don't attach any patches inline anymore.
> > I spent way too much time ripping out the patch from my email client and
> > then had to properly format the patch just to get it to apply.
> 
> Thanks for the updated patch.  I've attached what I currently have, but
>  I've not yet merged all of your changes into it yet.
> 
> This applies after my first patch (it replaces the second patch).
> 
> 
> Regards,
> Roger
> 

It didn't apply cleanly for me. I noticed the first hunk from the two patches 
adds "use Sbuild::ChrootRoot;", so I figure there's already some problem with 
the patch. I'll just wait until it's applied to the git tree rather than 
attempt to fix the patch again. I'll report problems then.

One thing I found wrong was the pipe_command() call for dpkg-parsechangelog. 
The hash needs to have 'DIR => getcwd()', else it will fail.

-- 
Regards,
Andres