[buildd-tools-devel] Bug#551311: Bug#551311: Updated patches for debuild like functionality in sbuild.

[Roger Leigh]

On Sat, Dec 12, 2009 at 12:42:10AM -0500, Andres Mejia wrote:
> On Friday 11 December 2009 07:17:04 Roger Leigh wrote:
> > On Thu, Dec 10, 2009 at 09:38:08PM -0500, Andres Mejia wrote:
> > > First I would like to say, thank you for reviewing my patches. :)
> > >
> > > Next I would like to say, please don't attach any patches inline anymore.
> > > I spent way too much time ripping out the patch from my email client and
> > > then had to properly format the patch just to get it to apply.
> > 
> > Thanks for the updated patch.  I've attached what I currently have, but
> >  I've not yet merged all of your changes into it yet.
> > 
> > This applies after my first patch (it replaces the second patch).
> > 
> > 
> > Regards,
> > Roger
> > 
> 
> It didn't apply cleanly for me. I noticed the first hunk from the two patches 
> adds "use Sbuild::ChrootRoot;", so I figure there's already some problem with 
> the patch. I'll just wait until it's applied to the git tree rather than 
> attempt to fix the patch again. I'll report problems then.

I've put all the current changes at
  git://git.debian.org/users/rleigh/sbuild.git
branch "debuild-am"

It's working for me so far.

> One thing I found wrong was the pipe_command() call for dpkg-parsechangelog. 
> The hash needs to have 'DIR => getcwd()', else it will fail.

I think this was caused by something else, since getcwd() is the
default.  It's working for me without this.


WRT the running external commands, I think prefer the
"hashref of arrayrefs of arrayrefs" you discussed in your
earlier post.  If you are happy with this, I think that's
the way to go.


Regards,
Roger

-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20091212/560be081/attachment.pgp>