[buildd-tools-devel] [GIT] sbuild branch, buildd-0.60.0, updated. debian/sbuild-0.60.0-1-72-g28f3d0e

[Roger Leigh]

On Fri, Mar 11, 2011 at 12:29:46PM +0000, Roger Leigh wrote:
> On Fri, Mar 11, 2011 at 10:49:24AM +0000, Roger Leigh wrote:
> > On Fri, Mar 11, 2011 at 10:28:05AM +0000, Roger Leigh wrote:
> > > On Sat, Mar 05, 2011 at 12:04:10PM +0100, Philipp Kern wrote:
> > > >     
> > > >     If $mime_build_log_mails is set to 1, then you will get a multipart/mixed mail
> > > >     comprising either one or two parts: the build log is always included as an
> > > >     attached file, the .changes file is attached only if the build completed
> > > >     successfully.  If $compress_build_log_mails is set to 1, then the build log
> > > >     will be sent gzip-encoded instead of plain text.
> > > >     
> > > >     Signed-off-by: Philipp Kern <pkern at debian.org>
> > > > 
> > > > If someone could come up with a better name for the configuration variable,
> > > > that would be helpful.  Also I think it wouldn't be totally insane to make
> > > > that the default.  Tests welcome, too.
> > > 
> > > I've tested both.  $mime_build_log_mails works just fine; if you want
> > > to make it the default, I'm happy with that.
> > > 
> > > $compress_build_log_mails appears to hang indefinitely at the end of
> > > the build.  Does this happen for you as well?  It's stuck in the
> > > send_compressed_build_log function while running sendmail (AFAICT
> > > from ps).
> > > 
> > > send_mail was being called /before/ the build log was closed.  I
> > > moved it to after in case it was waiting for it to close, but to no
> > > effect.
> > 
> > Only this setting is broken:
> > $mime_build_log_mails = 0;
> > $compress_build_log_mails = 1;
> > 
> > These work just fine:
> > $mime_build_log_mails = 1;
> > $compress_build_log_mails = 0;
> > 
> > $mime_build_log_mails = 1;
> > $compress_build_log_mails = 1;
> > 
> > So it appears to be in send_compressed_build_log.
> 
> It's getting stuck here:
> 
> 	print MAIL encode_base64($buf);
> 
> Presumably, it's not returning from encode_base64.
> 
> With the support for compressed logs in the MIME format, do we also
> need to support compressed logs on their own?

Hi Phil,

Just wondering if you'd had a chance to reproduce or investigate
this yet?  I'd like to make a release sometime this week, and I
would prefer to have this fixed (or the feature disabled if it's
not easily fixable in the short term) so that users won't get sbuild
hanging on them with the feature enabled.


Many thanks,
Roger


-- 
  .''`.  Roger Leigh
 : :' :  Debian GNU/Linux             http://people.debian.org/~rleigh/
 `. `'   Printing on GNU/Linux?       http://gutenprint.sourceforge.net/
   `-    GPG Public Key: 0x25BFB848   Please GPG sign your mail.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.alioth.debian.org/pipermail/buildd-tools-devel/attachments/20110314/5b0eff67/attachment.pgp>