[parted-devel] md blacklisting breaks Debian installer RAID support

Jim Meyering jim at meyering.net
Fri Jul 24 12:58:17 UTC 2009


Colin Watson wrote:
> The blacklisting of md devices in
> http://git.debian.org/?p=parted/parted.git;a=commit;h=f94e08bdb4ba0fa1b9fd35509e04c2d9ee84ff80
> breaks RAID support in the Debian installer, because we're expecting to
> be able to walk all devices libparted knows about and find /dev/md0 etc.
> after setting up arrays. While we don't actually want to attempt to put
> partition tables on these devices, it's still useful to have libparted
> recognise these devices; there are things it can do other than creating
> partition tables ...
>
> How about this patch instead (against next, but should be pretty close
> to master as well)? We use "loop" labels as fake partition tables for
> things that are essentially just a single filesystem directly on a
> disk-like block device, so it makes sense never to apply partition table
> changes to those.
...
> Date: Fri, 24 Jul 2009 12:43:42 +0100
> Subject: [PATCH] Recognise md devices again, but understand that they can't be partitioned
>
> * libparted/arch/linux.c (_skip_entry): Don't skip "md" devices.
> (_has_partitions): New function; "loop" labels can't be partitioned.
> (_blkpg_add_partition, _blkpg_remove_partition, _dm_add_partition,
> _have_blkpg): Don't attempt to apply partition table changes to
> unpartitionable devices.

This looks fine.
I have rebased next and pushed it there, for starters.

Thanks!



More information about the parted-devel mailing list