Bug#428459: xchat-gnome: _() implicitly converted to pointer

[dann frazier]

Package: xchat-gnome
Version: 1:0.17-1
Severity: important
Tags: patch
Usertags: implicit-pointer-conversion

Our automated buildd log filter[1] detected a problem that is likely to
cause your package to segfault on architectures where the size of a
pointer is greater than the size of an integer, such as ia64 and amd64.

This is often due to a missing function prototype definition.

The following patch replaces '_(...)' with 'gettext(...)' along with
the intltool definition. I'm guessing that this has the intended
functionality, but I could be wrong - I'm not too familiar with
l10n functionality.

[1]http://people.debian.org/~dannf/check-implicit-pointer-functions

----- Forwarded message from Build Daemon <buildd at excelsior.roeckx.be> -----

X-Spam-Checker-Version: SpamAssassin 3.1.7-deb (2006-10-05) on ldl.fc.hp.com
X-Spam-Level: 
X-Spam-Status: No, score=-1.3 required=3.5 tests=AWL,BAYES_00,UNDISC_RECIPS 
	autolearn=disabled version=3.1.7-deb
X-Virus-Scanned: Debian amavisd-new at ldl.fc.hp.com
Subject: Log for successful build of xchat-gnome_1:0.17-1 (dist=unstable)
Date: Mon, 11 Jun 2007 11:53:39 +0000 (GMT)
From: Build Daemon <buildd at excelsior.roeckx.be>
To: undisclosed-recipients: ;
X-PMX-Version: 5.3.1.294258, Antispam-Engine: 2.5.1.298604, Antispam-Data: 2007.6.11.43145
Debian-Buildd-Error: Yes

Function `_' implicitly converted to pointer at python.c:2081
Function `_' implicitly converted to pointer at tclplugin.c:2218

----- End forwarded message -----

--- xchat-gnome-0.17.orig/plugins/tcl/tclplugin.c	2007-03-06 15:47:26.000000000 -0700
+++ xchat-gnome-0.17/plugins/tcl/tclplugin.c	2007-06-11 16:00:04.000000000 -0600
@@ -28,6 +28,7 @@
 #include <tcl.h>
 #include <tclDecls.h>
 #include <sys/stat.h>
+#include <libintl.h>
 
 #ifdef WIN32
 #include <windows.h>
@@ -2215,8 +2216,8 @@
 void xchat_plugin_get_info(char **name, char **desc, char **version, void **reserved)
 {
    strncpy(PVERSION, &RCSID[19], 5);
-   *name = _("tclplugin");
-   *desc = _("Tcl plugin for XChat");
+   *name = gettext("tclplugin");
+   *desc = gettext("Tcl plugin for XChat");
    *version = PVERSION;
    if (reserved)
       *reserved = NULL;
--- xchat-gnome-0.17.orig/plugins/python/python.c	2007-03-06 15:47:26.000000000 -0700
+++ xchat-gnome-0.17/plugins/python/python.c	2007-06-11 15:52:20.000000000 -0600
@@ -57,6 +57,7 @@
 #include <stdlib.h>
 #include <sys/types.h>
 #include <dirent.h>
+#include <libintl.h>
 
 #include "xchat-plugin.h"
 #include "Python.h"
@@ -2078,9 +2079,9 @@
 	}
 	initialized = 1;
 
-	*plugin_name = _("Python");
+	*plugin_name = gettext("Python");
 	*plugin_version = VERSION;
-	*plugin_desc = _("Python scripting interface");
+	*plugin_desc = gettext("Python scripting interface");
 
 	/* Initialize python. */
 	Py_SetProgramName("xchat");

-- 
dann frazier