Bug#600486: Bug#598132: gdm3: Should beep or permit to configure a beep

[Josselin Mouette]

Le mardi 19 octobre 2010 à 16:39 +0200, Samuel Thibault a écrit :
> Josselin Mouette, le Tue 19 Oct 2010 16:17:45 +0200, a écrit :
> > In this case I don’t understand why you use 2 different GConf keys for
> > that effect.
> 
> Err, which 2 different GConf keys?  I'm just using the
> 
> /desktop/gnome/applications/at/beep_enabled
> 
> key everywhere.

D’oh. Sorry, I misread that too.

> > I’d prefer if the beep was emitted by a new g-s-d plugin,
> 
> Why doing so?  Writing a plugin seems much more involved than just
> putting a .desktop file in gdm3, I wonder for which benefit.

You are adding functionality to g-s-d that only works for gdm3. That’s
the path downwards confusion when you create a new configuration item
that will not do anything when checked.

To sum up: either you do the changes in g-s-d and have gdm set them in
its GConf configuration, or you do the changes in gdm and set them in
gdm’s own configuration. The latter is still my favorite, and above all
I’m not for a half-baked mix of both solutions.

Also note that it is quite late to introduce a new string in the
configuration box. It wouldn’t be translated to more than a handful of
languages at the time of the release. I’d prefer if we just stuck to
making something that works - gdm2 has always beeped when ready, and I
don’t recall people complaining of that.

> > In this case we shouldn’t forget the correct X-GNOME-Autostart-Phase
> > so that the beep only happens when everything else is ready.
> 
> Ah, I didn't know about that thing.  I guess we can move
> gdm-simple-greeter.desktop.in to Desktop phase, and the beep task to
> Application phase?

I guess that wouldn’t work anyway, since gdm-simple-greeter doesn’t
register itself to the session manager.

Cheers,
-- 
 .''`.
: :' :     “You would need to ask a lawyer if you don't know
`. `'       that a handshake of course makes a valid contract.”
  `-        --  J???rg Schilling