[Pkg-javascript-devel] Please review (and eventualy upload) jquery-simpletreemenu

[François-Régis]

Hi Emilien,

Thanks for your review,

Le 03/04/2014 22:46, Emilien Klein a écrit :
> 2014-04-01 23:08 GMT+02:00 François-Régis <frv-debian at miradou.com>:
>> I've pushed jquery-simpletreemenu on anonscm [1], could someone have a
>> look at it and tell me how horrible it is ?
> 
> - d/copyright:
>   * inconsistent name of upstream contact (Freytag vs. Freitag).
> According to github, it's "Simon Freytag"

You're right, done.

>   * Include upstream email address as part of Upstream-Contact (from
> his website: simon at freytag.org.uk)

Did'nt find it, thank you, done.

>   * you have to mention the copyright on the debian/* files (you can
> use same-as-upstream, but have to list yourself as copyright holder)

See next mail.

>   * Upstream-Name is incorrect (likely "Simple Tree Menu")

You're (again) right, my Upstream-Name is wrong. What induce you to
propose "Simple Tree Menu" ? Would'nt be better to take the github name:
"Simple-Tree-Menu" ?

>   * Where did you get the year 2010 as start of copyright? The git
> repo starts in 2012 with a mention of a previous manual zip file.

I've found it by searching the original source and I should have kept
the link but I did'nt and can't find the source anymore... I drop 2010
(It's a pity as I'm sure it was the first release... ).

> - d/upstream-changelog: the file ends with "Version 1.5.0: Moved to
> github, effectively ending this changelog; changes will now just be
> the [git log]"
> Do you plan to update it with the actual git log? Otherwise I'm not
> sure this file brings much benefit in including in the Debian package,
> as it will only be a forever outdated changelog.

I've just added this file to have sort of history before github, it's
not intended to be updated as upstream shows they will not maintain
further changelog.

Thanks Emilien, it's always a pleasure to read youre reviews.

Regards,

PS; I delay push until finding the good upstream name...

-- 
François-Régis