[Pkg-mailman-hackers] Bug#440163: Bug#440163: newlist never passes emailhost to list creator

[martin f krafft]

also sprach Thijs Kinkhorst <thijs at debian.org> [2007.12.01.1924 +0100]:
> Thanks - but a few rows below is this:
>         # Assign domain-specific attributes
>         mlist.host_name = host_name
> (host_name is set to emailhost earlier)
> 
> emailhost can indeed be passed to Create() aswell... is there a specific 
> problem you've experienced that this solved?

This code is so incredibly ugly. So yes, host_name and emailhost are
identical. The key is in mlist.Create: if emailhost==None, then it's
set to mm_cfg.DEFAULT_EMAIL_HOST, which is *not* translated via
mm_cfg.VIRTUAL_HOSTS. Thus, the posting address is wrong in the case
of virtual domains. Potentially, this could be fixed differently,
but I found the solution I suggested to be the least intrusive one.
This code is so incredibly ugly.

-- 
 .''`.   martin f. krafft <madduck at debian.org>
: :'  :  proud Debian developer, author, administrator, and user
`. `'`   http://people.debian.org/~madduck - http://debiansystem.info
  `-  Debian - when you have better things to do than fixing systems
 
"god is a comedian playing to an audience too afraid to laugh."
                                                           -- voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature (see http://martin-krafft.net/gpg/)
Url : http://lists.alioth.debian.org/pipermail/pkg-mailman-hackers/attachments/20071204/8134b2f5/attachment.pgp