[Pkg-mailman-hackers] Bug#440163: Bug#440163: Bug#440163: newlist never passes emailhost to list creator

[Thijs Kinkhorst]

Hi Martin,

On Tuesday 4 December 2007 11:04, Thijs Kinkhorst wrote:
> On Tuesday 4 December 2007 11:02, martin f krafft wrote:
> > This code is so incredibly ugly. So yes, host_name and emailhost are
> > identical. The key is in mlist.Create: if emailhost==None, then it's
> > set to mm_cfg.DEFAULT_EMAIL_HOST, which is *not* translated via
> > mm_cfg.VIRTUAL_HOSTS. Thus, the posting address is wrong in the case
> > of virtual domains. Potentially, this could be fixed differently,
> > but I found the solution I suggested to be the least intrusive one.
>
> Ah, right. I'll pass this on to upstream to get it resolved.

Here's upstream's response. Reading the code seems to support this view. 
emailhost is really a quite irrelevant parameter to this code as far as I can 
judge it.

====
It is true that newlist does not pass the email host name (actually
host_name, not emailhost at this point in the code) to Create(), but
immediately following a successful mlist.Create(), it does:

        # Assign domain-specific attributes
        mlist.host_name = host_name
        mlist.web_page_url = web_page_url

To set the list's host_name attribute.

The only thing Create() uses emailhost for is to append it to the listname
to make 'listname at emailhost' in order to determine that this is a valid
email address, but the intent of this is to validate the listname, not the
emailhost. Create() does not set any list attribute from emailhost.
====

Do you think there's anything more to be done about this bug? Or do you 
experience anything concrete that is caused by this and resolved by changing 
the call to Create()?


Thijs
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 481 bytes
Desc: not available
Url : http://lists.alioth.debian.org/pipermail/pkg-mailman-hackers/attachments/20071220/eb967527/attachment.pgp