Comments regarding libsereal-decoder-perl_0.31-1_amd64.changes

[Florian Schlichting]

Hi Alex,

On Tue, Apr 30, 2013 at 04:29:22PM +0200, Alex Mestiashvili wrote:
> I've updated libsereal-encoder-perl according
> http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/2013-March/060871.html
> Could you please have a look if it is correct?

I've just had a look at libsereal-{en,de}coder-perl, and I find the
following things to consider:

- srl_common.h does contain the comment "inspired by JSON::XS code", but
  a) that may only apply to the five lines immediately following it, and
  b) if that really means "inspired" rather than "copied literally", the
  file is still under the copyright of the main module authors, and a
  comment like "parts of srl_common.h inspired by Marc Lehmann's
  JSON::XS" might be added to "Files: *" instead

- then again the paragraph in lib/Sereal/Decoder.pm's pod suggests the
  overlap/copying from JSON::XS is more substantial and may reach beyond
  the very short header file, likely concerning the other srl_* files as
  well. Perhaps best to take that paragraph from the pod and add it as a
  comment to the Files: * section: 

    "Some inspiration and code was taken from Marc Lehmann's
    excellent JSON::XS module due to obvious overlap in
    problem domain."

- lib/Sereal/Decoder.pm license is *not* BSD-3-clause, even though that
  license text is reproduced there to describe the Snappy license. It's
  actually "same as Perl"

- then ptable.h carries the comment "Taken from Chocolateboy's autobox
  module." at the very top, which looks more like a verbatim code copy,
  but check with the autobox source

- and at the top of typemap, it says 'from "perlobject.map"  Dean
  Roehrich, version 19960302'

Florian