Comments regarding libsereal-decoder-perl_0.31-1_amd64.changes

[Alex Mestiashvili]

On 05/03/2013 09:04 AM, Florian Schlichting wrote:
> Hi Alex,
>
> On Tue, Apr 30, 2013 at 04:29:22PM +0200, Alex Mestiashvili wrote:
>   
>> I've updated libsereal-encoder-perl according
>> http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/2013-March/060871.html
>> Could you please have a look if it is correct?
>>     
> I've just had a look at libsereal-{en,de}coder-perl, and I find the
> following things to consider:
>
> - srl_common.h does contain the comment "inspired by JSON::XS code", but
>   a) that may only apply to the five lines immediately following it, and
>   b) if that really means "inspired" rather than "copied literally", the
>   file is still under the copyright of the main module authors, and a
>   comment like "parts of srl_common.h inspired by Marc Lehmann's
>   JSON::XS" might be added to "Files: *" instead
>   

Hi Florian,
I think that it is "copied literally"

this is the code from JSON::XS, [0] see lines 52-58.

#if __GNUC__ >= 3
# define expect(expr,value)         __builtin_expect ((expr), (value))
# define INLINE                     static inline
#else
# define expect(expr,value)         (expr)
# define INLINE                     static
#endif

and this is the code from srl_common.h

/* inspired by JSON::XS code */
#if __GNUC__ >= 3
# define expect(expr,value) __builtin_expect((expr), (value))
#else
# define expect(expr,value) (expr)
#endif


> - then again the paragraph in lib/Sereal/Decoder.pm's pod suggests the
>   overlap/copying from JSON::XS is more substantial and may reach beyond
>   the very short header file, likely concerning the other srl_* files as
>   well. Perhaps best to take that paragraph from the pod and add it as a
>   comment to the Files: * section: 
>
>     "Some inspiration and code was taken from Marc Lehmann's
>     excellent JSON::XS module due to obvious overlap in
>     problem domain."
>
> - lib/Sereal/Decoder.pm license is *not* BSD-3-clause, even though that
>   license text is reproduced there to describe the Snappy license. It's
>   actually "same as Perl"
>   
yes, true, thanks !
> - then ptable.h carries the comment "Taken from Chocolateboy's autobox
>   module." at the very top, which looks more like a verbatim code copy,
>   but check with the autobox source
>   
It differs quite a lot from the autobox code, so it is not a verbatim copy.
> - and at the top of typemap, it says 'from "perlobject.map"  Dean
>   Roehrich, version 19960302'
>
>   
I see, added section.
But there is a problem - the perlobject.map has no license as fas as I
see...

> Florian
>   

Thanks a lot for the detailed review!

Alex

[0] 
http://anonscm.debian.org/gitweb/?p=pkg-perl/packages/libjson-xs-perl.git;a=blob;f=XS.xs;h=c140314eaea3defee579aab3f9320d03e2698256;hb=c6ccf6ef72f8b64b0020aea1338c43f49ec7a86b