Bug#834199: dh-make-perl: Uses deprecated Dpkg::Source:Package variable

[gregor herrmann]

On Sun, 14 Aug 2016 14:03:47 +0200, Guillem Jover wrote:

> > (In a quite ugly way, since "use constant foo => qr/STRING/" works
> > but not the same with a FUNCTION. Improvements welcome.)
> Do you really need to coerce it into a qr// though? AFAICS
> parse_command_line_options is also setting DEFAULTS->{exclude} and
> does not set it as a qr//, maybe that's also being done when being
> used?

Ha, nice catch, thank you.
This is inconsistent indeed.

I've now dropped the qr//, as the tests seem to pass without as well
(I added a to-be-ignored file to the test distribution).
 
> > > (For reference, this is documented in the man page for the module and
> > > was mentioned in the debian/changelog. I'm not sure how to make this
> > > kind of thing more visible to API users, 
> > Good question. I read the changelog of important packages like dpkg
> > carefully but I didn't know by heart that dh-make-perl uses
> > $diff_ignore_default_regexp ... I guess in the end there's no real
> > safe alternative to bug reports after the fact :/
> Right, in the end I guess someone might need to do an archive wide
> grep to catch these kind of usages, so whoever does the deprecation
> is in the best position to do so. 

https://codesearch.debian.net/search?q=diff_ignore_default_regexp
shows only dpkg and dh-make-perl.


Cheers,
gregor

-- 
 .''`.  Homepage https://info.comodo.priv.at/ - OpenPGP key 0xBB3A68018649AA06
 : :' : Debian GNU/Linux user, admin, and developer -  https://www.debian.org/
 `. `'  Member of VIBE!AT & SPI, fellow of the Free Software Foundation Europe
   `-   NP: Red Hot Chili Peppers: Californication
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 949 bytes
Desc: Digital Signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-perl-maintainers/attachments/20160814/6905af04/attachment-0001.sig>