Bug#834199: dh-make-perl: Uses deprecated Dpkg::Source:Package variable

[Guillem Jover]

On Sun, 2016-08-14 at 05:14:48 +0200, gregor herrmann wrote:
> On Sat, 13 Aug 2016 02:03:19 +0200, Guillem Jover wrote:
> 
> > This package uses the scalar $diff_ignore_default_regexp from the
> > Dpkg::Source::Package module, which was deprecated in dpkg 1.17.2.
> > Please switch to use the get_default_diff_ignore_regex() function.
> 
> Fixed in git.

Perfect thanks!

> (In a quite ugly way, since "use constant foo => qr/STRING/" works
> but not the same with a FUNCTION. Improvements welcome.)

Do you really need to coerce it into a qr// though? AFAICS
parse_command_line_options is also setting DEFAULTS->{exclude} and
does not set it as a qr//, maybe that's also being done when being
used?

> > (For reference, this is documented in the man page for the module and
> > was mentioned in the debian/changelog. I'm not sure how to make this
> > kind of thing more visible to API users, 
> 
> Good question. I read the changelog of important packages like dpkg
> carefully but I didn't know by heart that dh-make-perl uses
> $diff_ignore_default_regexp ... I guess in the end there's no real
> safe alternative to bug reports after the fact :/

Right, in the end I guess someone might need to do an archive wide
grep to catch these kind of usages, so whoever does the deprecation
is in the best position to do so. Of course that leave out sources
outside of the archive. :/ At least in the future dpkg will have less
public variables, which means deprecations are easier to handle! :)

Thanks,
Guillem