Ask for review

[Lukas Schwaighofer]

Hi,

I've looked at most of the packages you mentioned now. I've pushed the
changes to rfdump and autolog explained below to their respective
repositories already. If you disagree with any of them feel free to
revert.

On Sun, 9 Apr 2017 16:30:15 +0200
Marcos Fouces <marcos.fouces at gmail.com> wrote:

> I had some spare time and i decided to try to adopt some 
> security-related orphaned packages.
> 
> Should be good if someone could review them.
> 
> * https://anonscm.debian.org/cgit/pkg-security/knocker.git/
Your changes look fine to me.

> * https://anonscm.debian.org/cgit/pkg-security/libnids.git/
separate mail; one thing I noticed in addition to what I already
wrote: your commit which updates the changelog
(a36b75abdab9426d4d740e2fd911a937d1e18217) drops the notice that
-fno-strict-aliasing was added, probably that should be re-added to the
changelog.

> * https://anonscm.debian.org/cgit/pkg-security/rfdump.git/
`-g` should not be a CPPFLAG (it's not used by the preprocessor).
Instead I have patched the build system to properly use the supplied
CFLAGS, so adding that explicitly is no longer necessary.

Now that the CFLAGS from dpkg-buildflags are used in the build process,
-Werror=format-security caused warnings to become errors; I fixed them
in a separate patch.

I also added -Wl,--as-needed to LDFLAGS to avoid excessive linking.

> * https://anonscm.debian.org/cgit/pkg-security/snoopy.git/
> * https://anonscm.debian.org/cgit/pkg-security/swatch.git/
Those two are still on my TODO list.

> I also fixed some bugs, Lintian warnings, new release...  in the 
> following packages:
> 
> * https://anonscm.debian.org/cgit/pkg-security/dsniff.git/
(reviewed separately already)

> * https://anonscm.debian.org/cgit/pkg-security/autolog.git/
I adjusted your Makefile patch to also allow overriding the CC variable
(otherwise cross compiling will probably not work). Since I only made a
minor change to your patch I didn't add my name to the changelog, but I
adjusted your changelog entry a bit.  If that should have been handled
differently please let me know.

> * https://anonscm.debian.org/cgit/pkg-security/acct.git/
Looks good, I only noticed that your change of the Dependencies in
debian/control introduced inconsistent whitespace, but it seemed too
insignificant to modify.

> * https://anonscm.debian.org/cgit/pkg-security/recon-ng.git/

I don't see any problems, but there are some things I don't
understand. E.g. `dh --with-python2` was at some point removed
by Raphaël Hertzog (for a Kali version) with a changelog entry "Stop
using dh_python2 as we don't want byte-compilation of .py files (on
request of the upstream author)."


Regards
Lukas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-security-team/attachments/20170421/0bf9e108/attachment.sig>