Ask for review

[Raphael Hertzog]

On Fri, 21 Apr 2017, Lukas Schwaighofer wrote:
> > * https://anonscm.debian.org/cgit/pkg-security/rfdump.git/
> `-g` should not be a CPPFLAG (it's not used by the preprocessor).
> Instead I have patched the build system to properly use the supplied
> CFLAGS, so adding that explicitly is no longer necessary.
> 
> Now that the CFLAGS from dpkg-buildflags are used in the build process,
> -Werror=format-security caused warnings to become errors; I fixed them
> in a separate patch.

Can you submit those patches upstream? In general, all build systems
improvements should be submitted so that we don't have to maintain
those patches in Debian.

> > * https://anonscm.debian.org/cgit/pkg-security/recon-ng.git/
> 
> I don't see any problems, but there are some things I don't
> understand. E.g. `dh --with-python2` was at some point removed
> by Raphaël Hertzog (for a Kali version) with a changelog entry "Stop
> using dh_python2 as we don't want byte-compilation of .py files (on
> request of the upstream author)."

This is a change I made a long time ago. The upstream author was
unhappy because the .pyc would stay around when he updated his software
through something else than dpkg (not sure if recon-ng has an auto-update
mechanism that could trigger this).

But this is not necessarily a change that we want in Debian. We are not
interested in supporting updates through something else than packages.

Cheers,
-- 
Raphaël Hertzog ◈ Debian Developer

Support Debian LTS: https://www.freexian.com/services/debian-lts.html
Learn to master Debian: https://debian-handbook.info/get/