Bug#865223: acct: new init script is broken

[Lukas Schwaighofer]

Hi Marcos,

On Thu, 29 Jun 2017 07:34:30 +0200
Marcos Fouces <marcos.fouces at gmail.com> wrote:

> I investigate more deeply this issue and i realized that i updated
> start and stop functions for no purpose. There is not any improvement
> with those change as the previous script performed well
> 
> I suggest reverting to the previous version that you can see here:
> 
> https://anonscm.debian.org/cgit/pkg-security/acct.git/tree/debian/acct.init.d?h=debian/6.5.5-2.1

Looks reasonable, although the start_daemon shell function is probably
doing more harm than good (possibly changes the exit code).  I
would rather remove it.

The check for exit code 38 (ENOSYS) seems correct and matches the
acct(2) man page.  I don't know about exit code 16 (EBUSY) though, but
keeping it shouldn't do harm.

> Perhaps we could add status option but i think that anymore changes
> are needed at this moment.

There doesn't seem to be a way to find out if acct is enabled using the
acct syscall or the accton binary.  Unless we have a way of asking the
kernel whether it's enabled, I don't think we can implement the status
option in a reliable way.

Regards
Lukas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <http://lists.alioth.debian.org/pipermail/pkg-security-team/attachments/20170629/822d33e4/attachment.sig>